Skip to content

Outdated instructions for "Manual Configuration" of debug symbols upload on iOS #2483

@birdofpreyru

Description

@birdofpreyru

This is a documentation issue. Here you say "we modify Bundle React Native code and images phase" from:

export NODE_BINARY=node
../node_modules/react-native/packager/react-native-xcode.sh

as of RN@0.70.1 the original script in that phase looks like this

set -e
WITH_ENVIRONMENT="../node_modules/react-native/scripts/xcode/with-environment.sh"
REACT_NATIVE_XCODE="../node_modules/react-native/scripts/react-native-xcode.sh"
/bin/sh -c "$WITH_ENVIRONMENT $REACT_NATIVE_XCODE";

and the next snippet does not work for me:

export NODE_BINARY=node
export EXTRA_PACKAGER_ARGS="--sourcemap-output $DERIVED_FILE_DIR/main.jsbundle.map"
export SENTRY_PROPERTIES=../sentry.properties

# If you are using RN 0.46+
../node_modules/@sentry/cli/bin/sentry-cli react-native xcode \
  ../node_modules/react-native/scripts/react-native-xcode.sh

It should be changed to something like this, I believe:

set -e

export EXTRA_PACKAGER_ARGS="--sourcemap-output $DERIVED_FILE_DIR/main.jsbundle.map"
export SENTRY_PROPERTIES="$SRCROOT/sentry.properties"

WITH_ENVIRONMENT="../node_modules/react-native/scripts/xcode/with-environment.sh"
REACT_NATIVE_XCODE="../node_modules/react-native/scripts/react-native-xcode.sh"

$WITH_ENVIRONMENT "../node_modules/@sentry/cli/bin/sentry-cli react-native xcode"
/bin/sh -c "$WITH_ENVIRONMENT $REACT_NATIVE_XCODE"

Similarly, the code in the next section does not seem to work for me, unless changed into:

export SENTRY_PROPERTIES=$SRCROOT/sentry.properties
WITH_ENVIRONMENT="$SRCROOT/../node_modules/react-native/scripts/xcode/with-environment.sh"

$WITH_ENVIRONMENT "$SRCROOT/../node_modules/@sentry/cli/bin/sentry-cli upload-dif $DWARF_DSYM_FOLDER_PATH"

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions