Use cached methods SentryDebugImageProvider of the Cocoa SDK

[philipphofmann]

Description

Replace

sentry-react-native/ios/RNSentry.mm

Line 323 in a371274

NSArray<SentryDebugMeta *> *debugMetaImages = [[[SentryDependencyContainer sharedInstance] debugImageProvider] getDebugImagesForAddresses:imagesAddrToRetrieveDebugMetaImages isCrash:false];

with either SentryDebugImageProvider.getDebugImagesFromCacheForFrames or SentryDebugImageProvider.getDebugImagesFromCacheForThreads added in getsentry/sentry-cocoa#4435, which will most likely ship with Cocoa 8.39.0. getDebugImagesForAddresses is slow and caused AppHangs on iOS; see getsentry/sentry-cocoa#4399.

[antonis]

Hey @philipphofmann, @krystofwoldrich 👋
Following up on the conversation here, would it make sense to also expose the getDebugImagesForImageAddressesFromCache in the SentryDebugImageProvider+HybridSDKs.h?
The method is used in the getDebugImagesFromCacheForFrames and getDebugImagesFromCacheForThreads implementation that are exposed and could make the RN side migration more straightforward.

sentry-react-native/packages/core/ios/RNSentry.mm

Line 323 in a989877

NSArray<SentryDebugMeta *> *debugMetaImages = [[[SentryDependencyContainer sharedInstance] debugImageProvider] getDebugImagesForAddresses:imagesAddrToRetrieveDebugMetaImages isCrash:false];

I can open a PR on sentry-cocoa if you agree or use the private method.

[krystofwoldrich]

Yes, let's add getDebugImagesForImageAddressesFromCache to the hybrid SDKs header.

[antonis]

Yes, let's add getDebugImagesForImageAddressesFromCache to the hybrid SDKs header.

Opened getsentry/sentry-cocoa#4460 and I plan to update my RN PR that currently uses the private method as soon as the next sentry-cocoa version is released.