You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@bruno-garcia What if we say that the RN SDK 5.x requires RN version >= 0.69?
We could technically drop stuff like #2015
It'd be easier to maintain as well since we don't need to test stuff on older versions, we'd need to patch bug fixes on v4.x when needed though.
Ideally not the best solution for the user, but this is a breaking change and auto-linking won't work for either before or after 0.69.
Sounds like it's it's time. Can we spit out build warnings/errors in case the expected version doesn't match? My biggest worry is of users getting unrelated error messages, being frustrated and/or raising issues with support.
If we can break at build time, with:
Sentry 5.0 on older RN: The Sentry SDK version 5.0.0 and above requires React Native 0.69 or higher
Sentry 4.x on older RN: The Sentry SDK version 4 doesn't support React Native 0.69. Please upgrade to Sentry 5.0.0 or higher
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Remove the removed config from the config file.
This is a breaking change.
💡 Motivation and Context
Fixes #2267
💚 How did you test it?
Running it
📝 Checklist
🔮 Next steps
Patch https://github.com/getsentry/sentry-wizard