Skip to content

Conversation

@krystofwoldrich
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

This PR updates getSentryExpoConfig:

  • matches method signature with getDefaultConfig so it can be a drop-in replacement
  • adds this method to sentry expo sample application
  • remove the check of graph.transformOptions.hot which was used to check if the function is running in development or production build but for web builds this option is always true
    • now the function only relies on the presence of Debug ID, which is currently only created for production builds
  • add extra empty lines around the warning otherwise it might be overwritten by the interactive progress bar

💚 How did you test it?

sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 8592bcb

Base automatically changed from kw-expo-update-preview-7 to expo January 8, 2024 18:18
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krystofwoldrich krystofwoldrich merged commit 2e40f57 into expo Jan 8, 2024
@krystofwoldrich krystofwoldrich deleted the kw-update-get-sentry-expo-config branch January 8, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants