Skip to content

Conversation

@krystofwoldrich
Copy link
Contributor

@krystofwoldrich krystofwoldrich commented Mar 27, 2024

Updates the React Native integration to use the new factory functions returning plain JS object style.

@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Update integration to new JS interface ([#3721](https://github.com/getsentry/sentry-react-native/pull/3721))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 67b61f4

@github-actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 412.23 ms 434.44 ms 22.21 ms
Size 17.73 MiB 19.93 MiB 2.20 MiB

@github-actions
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 368.04 ms 393.08 ms 25.04 ms
Size 7.15 MiB 8.20 MiB 1.06 MiB

@github-actions
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1198.10 ms 1199.45 ms 1.35 ms
Size 2.36 MiB 2.92 MiB 569.46 KiB

@kahest kahest added this to the 6.0.0 milestone Apr 2, 2024
hint.syntheticException.stack,
getFramesToPop(hint.syntheticException),
);
export const debugSymbolicatorIntegration: IntegrationFn = () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should backport the integrations to a v5 release so that users can migrate to the functional integrations more incrementally.

You can look at https://github.com/getsentry/sentry-javascript/blob/fdcd1adfe65becd9c605412cdd474eb676714bc4/packages/integrations/src/dedupe.ts#L9-L45 as an example of this in v7.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree, I'll prepare it.

Base automatically changed from kw-rn-error-handlers-update-tests to v6 April 3, 2024 10:12
@krystofwoldrich
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants