feat(core): Bump sentry-javascript to version 8 #3836
Conversation
|
Android (legacy) Performance metrics 🚀
|
krystofwoldrich
changed the title
src/js/profiling/integration.ts
Outdated
|
|
||
| const _createProfileEventFor = (profiledTransaction: Event): ProfileEvent | null => { | ||
| const profile_id = profiledTransaction?.contexts?.['profile']?.['profile_id']; | ||
| const profile_id = profiledTransaction?.contexts?.['trace']?.['data']?.['profile_id']; |
There was a problem hiding this comment.
Should we refer to profiledTransaction as profiledEvent or profiledSpan since transactions are no longer used?
There was a problem hiding this comment.
Yes, make sense, I agree, but let's do it in another PR, to avoid adding more change to this, it's already a large PR.
Android (new) Performance metrics 🚀
|
| public init(): void { | ||
| super.init(); | ||
| this._initNativeSdk(); | ||
| super.init(); |
There was a problem hiding this comment.
Q: Was it previously wrong and you fix it now or is it a change that was required for V8?
There was a problem hiding this comment.
The init was added for V8, the native init needs to happen before the JS init, to avoid the native not available error log in Expo.
Before v8 the native init happened in constructor, which doesn't make sense with dedicate init method.
lucas-zimerman
left a comment
lucas-zimerman
left a comment
There was a problem hiding this comment.
a minor question but other than that LGTM!
📢 Type of change
📜 Description
sentry-javascriptto version 8 #3736💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog