-
-
Notifications
You must be signed in to change notification settings - Fork 357
(1) ref(tracing): extract app start to a standalone integration #3852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Android (legacy) Performance metrics 🚀
|
iOS (legacy) Performance metrics 🚀
|
iOS (new) Performance metrics 🚀
|
Android (new) Performance metrics 🚀
|
| // The first root component mount is the app start finish. | ||
| && tracingIntegration.onAppStartFinish(endTimestamp); | ||
| // eslint-disable-next-line @typescript-eslint/no-floating-promises | ||
| captureAppStart(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q:Shouldn't we wait for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only trigger the capture of app start here, recording the timestamp and I don't await it as the fetch from native layer can happen async later
lucas-zimerman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking question, LGTM!
📢 Type of change
📜 Description
Before this PR
ReactNativeTracingimplementation.After this PR
standaloneoption which let user change the behaviour. By default we check presence of routing instrumentation like before.Examples After
💚 How did you test it?
tests, sample app
📝 Checklist
sendDefaultPIIis enabled