Chore: Upgrade core to RN 0.75 #4173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # samples/react-native/package.json
Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
9 tasks
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d197b5c+dirty | 338.94 ms | 354.87 ms | 15.93 ms |
| 3ffcddd | 302.92 ms | 315.80 ms | 12.88 ms |
| 700cbf4 | 425.56 ms | 436.26 ms | 10.70 ms |
| 9433f35 | 347.64 ms | 356.22 ms | 8.58 ms |
| 70e6261 | 482.65 ms | 495.70 ms | 13.05 ms |
| 4a6664f | 548.79 ms | 585.00 ms | 36.21 ms |
| 5a22220 | 412.38 ms | 447.35 ms | 34.97 ms |
| b1e8712 | 462.11 ms | 465.71 ms | 3.60 ms |
| 0db0c72 | 372.12 ms | 386.00 ms | 13.88 ms |
| ac41368 | 451.47 ms | 453.67 ms | 2.20 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d197b5c+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
| 3ffcddd | 17.73 MiB | 19.75 MiB | 2.02 MiB |
| 700cbf4 | 17.73 MiB | 20.07 MiB | 2.33 MiB |
| 9433f35 | 17.73 MiB | 19.81 MiB | 2.08 MiB |
| 70e6261 | 17.73 MiB | 19.94 MiB | 2.21 MiB |
| 4a6664f | 17.73 MiB | 19.94 MiB | 2.21 MiB |
| 5a22220 | 17.73 MiB | 19.93 MiB | 2.20 MiB |
| b1e8712 | 17.73 MiB | 19.75 MiB | 2.02 MiB |
| 0db0c72 | 17.73 MiB | 19.75 MiB | 2.02 MiB |
| ac41368 | 17.73 MiB | 20.11 MiB | 2.38 MiB |
Previous results on branch: antonis/rn-0.75.4-core
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2374c56 | 458.34 ms | 442.32 ms | -16.02 ms |
| 1d9d09f | 475.76 ms | 476.40 ms | 0.64 ms |
| cb3f65c | 477.32 ms | 468.93 ms | -8.39 ms |
| 043095f | 491.90 ms | 492.22 ms | 0.32 ms |
| 40940de | 475.86 ms | 485.71 ms | 9.86 ms |
| afce6ed | 488.57 ms | 526.24 ms | 37.67 ms |
| dd27cec | 496.40 ms | 521.70 ms | 25.30 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 2374c56 | 17.74 MiB | 20.07 MiB | 2.34 MiB |
| 1d9d09f | 17.74 MiB | 20.07 MiB | 2.34 MiB |
| cb3f65c | 17.74 MiB | 20.07 MiB | 2.34 MiB |
| 043095f | 17.74 MiB | 20.07 MiB | 2.34 MiB |
| 40940de | 17.74 MiB | 20.07 MiB | 2.34 MiB |
| afce6ed | 17.74 MiB | 20.07 MiB | 2.34 MiB |
| dd27cec | 17.74 MiB | 20.07 MiB | 2.34 MiB |
# Conflicts: # samples/react-native/android/app/src/release/java/io/sentry/reactnative/sample/ReactNativeFlipper.java
antonis
requested review from
krystofwoldrich and
lucas-zimerman
as code owners
lucas-zimerman
approved these changes
Oct 15, 2024
Collaborator
lucas-zimerman
left a comment
lucas-zimerman
left a comment
There was a problem hiding this comment.
Looks good to me, LGTM!
# Conflicts: # yarn.lock
This reverts commit c8bc67f.
lucas-zimerman
force-pushed
the
antonis/rn-0.75.4-core
branch
from
17f5779 to
5a74c05
Compare
# Conflicts: # packages/core/package.json # yarn.lock
krystofwoldrich
approved these changes
Oct 21, 2024
Contributor
krystofwoldrich
left a comment
krystofwoldrich
left a comment
There was a problem hiding this comment.
Thank you! Looks good! 🚀
Co-authored-by: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Based on: #4155
REACT_NATIVE_PATHthat was causing a failure in theRNSentryCocoaTesterdue to a newly introduced check in 0.75.4💡 Motivation and Context
See #4155 (comment)
💚 How did you test it?
CI and manual test
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog