Skip to content

Conversation

@krystofwoldrich
Copy link
Contributor

@krystofwoldrich krystofwoldrich commented Nov 4, 2024

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

This PR adds clang-format to yarn lint and yarn fix commands.

First commit adds the formatter.
Second commit changes are from the formatter.

Clang config file is copied from sentry-cocoa as that already uses the formatter. And it's similar mobile code base.

💡 Motivation and Context

There are over 70 clang file in the repository.

💚 How did you test it?

ci, locally

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

#skip-changelog

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀
Thank you for improving our tooling @krystofwoldrich 🙇

Only added a suggestion on an extra folder that can be ignored.

Co-authored-by: Antonis Lilis <antonis.lilis@gmail.com>
@krystofwoldrich krystofwoldrich enabled auto-merge (squash) November 5, 2024 10:21
@krystofwoldrich krystofwoldrich merged commit 08365b9 into main Nov 5, 2024
@krystofwoldrich krystofwoldrich deleted the kw/internal/clag-format branch November 5, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants