chore: Update PR template #4291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove I reviewed the code and add updating the wizard and the docs because we often forget to update these.
philipphofmann
requested review from
antonis,
krystofwoldrich and
lucas-zimerman
as code owners
lucas-zimerman
approved these changes
Nov 19, 2024
Collaborator
lucas-zimerman
left a comment
lucas-zimerman
left a comment
There was a problem hiding this comment.
I think this is a nice change since when you open a PR (not a draft) you are expected to have reviewed your submitted code.
antonis
approved these changes
Nov 20, 2024
Contributor
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
LGTM. Thank you for the update Philipp 🙇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove I reviewed the code and add updating the wizard and the docs because we often forget to update these.
#skip-changelog