Skip to content

Bug: Sentry Module Collection Script Fails with Spaces in Node Path #4559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krystofwoldrich merged 6 commits into from
Feb 20, 2025
Merged

Bug: Sentry Module Collection Script Fails with Spaces in Node Path #4559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a6b61ca
fix: module Collection Script Fails with Spaces in Node Path
avarayr Feb 18, 2025
eb67117
Update CHANGELOG.md
avarayr Feb 18, 2025
db87a9b
Merge branch 'main' into patch-1
avarayr Feb 19, 2025
70ba477
Update CHANGELOG.md
krystofwoldrich Feb 19, 2025
a68b42d
Merge branch 'main' into patch-1
krystofwoldrich Feb 19, 2025
34eb259
Merge branch 'main' into patch-1
avarayr Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@

### Fixes

- Sentry Module Collection Script Fails with Spaces in Node Path on iOS ([#4559](https://github.com/getsentry/sentry-react-native/pull/4559))
- Various crashes and issues of Session Replay on Android. See the Android SDK version bump for more details. ([#4529](https://github.com/getsentry/sentry-react-native/pull/4529))

### Dependencies
Expand Down
8 changes: 4 additions & 4 deletions packages/core/scripts/collect-modules.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ if [[ -n "$NODE_BINARY" ]]; then
nodePath="$NODE_BINARY"
fi

thisFilePath=$(dirname $0)
thisFilePath=$(dirname "$0")
collectModulesScript="$thisFilePath/../dist/js/tools/collectModules.js"

destination="$CONFIGURATION_BUILD_DIR/$UNLOCALIZED_RESOURCES_FOLDER_PATH"
Expand All @@ -44,11 +44,11 @@ else
modulesPaths="$MODULES_PATHS"
fi

type $nodePath >/dev/null 2>&1 || {
if ! command -v "$nodePath" >/dev/null 2>&1; then
echo >&2 "error: $nodePath not found! Modules won't be collected." \
"Please export NODE_BINARY in 'Build Phase' - 'Bundle React Native code and images'" \
"to an absolute path of your node binary. Check your node path by 'which node'."
exit 0 # Don't fail the build but inform about the problem
}
fi

$nodePath "$collectModulesScript" "$sourceMap" "$modulesOutput" "$modulesPaths"
"$nodePath" "$collectModulesScript" "$sourceMap" "$modulesOutput" "$modulesPaths"
Loading