Skip to content

fix(ios): When collect-modules fails to find a node path exit without errors #4570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krystofwoldrich merged 4 commits into from
Feb 20, 2025
Merged

fix(ios): When collect-modules fails to find a node path exit without errors #4570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
24853a9
fix(ios): When collect-modules fails to find a node path exit without…
krystofwoldrich Feb 19, 2025
78995e6
Update CHANGELOG.md
krystofwoldrich Feb 19, 2025
4c62cf6
Update collect-modules.sh
krystofwoldrich Feb 19, 2025
debc27c
Merge branch 'main' into krystofwoldrich-patch-1
krystofwoldrich Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@

### Fixes

- Remove `error:` prefix from `collect-modules.sh` to avoid failing iOS builds ([#4570](https://github.com/getsentry/sentry-react-native/pull/4570))
- Sentry Module Collection Script Fails with Spaces in Node Path on iOS ([#4559](https://github.com/getsentry/sentry-react-native/pull/4559))
- Various crashes and issues of Session Replay on Android. See the Android SDK version bump for more details. ([#4529](https://github.com/getsentry/sentry-react-native/pull/4529))

Expand Down
2 changes: 1 addition & 1 deletion packages/core/scripts/collect-modules.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ else
fi

if ! command -v "$nodePath" >/dev/null 2>&1; then
echo >&2 "error: $nodePath not found! Modules won't be collected." \
echo "[sentry/collect-modules.sh] $nodePath not found! Modules won't be collected." \
"Please export NODE_BINARY in 'Build Phase' - 'Bundle React Native code and images'" \
"to an absolute path of your node binary. Check your node path by 'which node'."
exit 0 # Don't fail the build but inform about the problem
Expand Down
Loading