fix: Changed gradle.projectsEvaluated to project.afterEvaluate in the Sentry Gradle Plugin to ensure tasks are created correctly with --configure-on-demand
#4687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the Sentry Gradle Plugin to ensure tasks are created correctly with `--configure-on-demand`
krystofwoldrich
requested review from
antonis and
lucas-zimerman
as code owners
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ae7b03d+dirty | 403.26 ms | 456.78 ms | 53.52 ms |
| 49ea1eb+dirty | 393.09 ms | 404.74 ms | 11.65 ms |
| 34aba08+dirty | 331.79 ms | 376.69 ms | 44.91 ms |
| 07e58c9+dirty | 391.00 ms | 409.66 ms | 18.66 ms |
| c314a21+dirty | 419.41 ms | 426.02 ms | 6.61 ms |
| 3ffcddd+dirty | 244.82 ms | 295.47 ms | 50.65 ms |
| 70caa60+dirty | 308.83 ms | 393.06 ms | 84.23 ms |
| 5a22220+dirty | 384.61 ms | 419.06 ms | 34.45 ms |
| e73d82f+dirty | 377.67 ms | 407.06 ms | 29.39 ms |
| de59d3a+dirty | 439.90 ms | 454.20 ms | 14.30 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ae7b03d+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 49ea1eb+dirty | 7.15 MiB | 8.40 MiB | 1.24 MiB |
| 34aba08+dirty | 7.15 MiB | 8.07 MiB | 946.13 KiB |
| 07e58c9+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| c314a21+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| 3ffcddd+dirty | 7.15 MiB | 8.04 MiB | 912.17 KiB |
| 70caa60+dirty | 7.15 MiB | 8.03 MiB | 901.79 KiB |
| 5a22220+dirty | 7.15 MiB | 8.21 MiB | 1.06 MiB |
| e73d82f+dirty | 7.15 MiB | 8.34 MiB | 1.19 MiB |
| de59d3a+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c991c90+dirty | 1211.13 ms | 1231.52 ms | 20.39 ms |
| 8b86336+dirty | 1219.38 ms | 1230.73 ms | 11.36 ms |
| 22e31b6+dirty | 1253.62 ms | 1265.96 ms | 12.34 ms |
| 8f0282e+dirty | 1215.46 ms | 1219.64 ms | 4.18 ms |
| 9385d74+dirty | 1215.18 ms | 1216.43 ms | 1.25 ms |
| 8bda0cc+dirty | 1221.90 ms | 1208.11 ms | -13.79 ms |
| e5bc97b+dirty | 1230.63 ms | 1234.83 ms | 4.20 ms |
| 80b2ce3+dirty | 1265.92 ms | 1268.60 ms | 2.69 ms |
| 60ad48c+dirty | 1214.22 ms | 1227.41 ms | 13.19 ms |
| 24cb2a4+dirty | 1224.30 ms | 1221.37 ms | -2.93 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c991c90+dirty | 2.63 MiB | 3.74 MiB | 1.11 MiB |
| 8b86336+dirty | 2.63 MiB | 3.68 MiB | 1.05 MiB |
| 22e31b6+dirty | 2.36 MiB | 2.87 MiB | 520.67 KiB |
| 8f0282e+dirty | 2.63 MiB | 3.76 MiB | 1.13 MiB |
| 9385d74+dirty | 2.36 MiB | 3.10 MiB | 759.78 KiB |
| 8bda0cc+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB |
| e5bc97b+dirty | 2.36 MiB | 3.10 MiB | 753.14 KiB |
| 80b2ce3+dirty | 2.36 MiB | 2.84 MiB | 486.98 KiB |
| 60ad48c+dirty | 2.63 MiB | 3.75 MiB | 1.12 MiB |
| 24cb2a4+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c991c90+dirty | 1231.45 ms | 1237.35 ms | 5.90 ms |
| 8b86336+dirty | 1236.26 ms | 1235.00 ms | -1.26 ms |
| 22e31b6+dirty | 1276.55 ms | 1278.12 ms | 1.57 ms |
| 8f0282e+dirty | 1225.33 ms | 1229.92 ms | 4.59 ms |
| 9385d74+dirty | 1239.51 ms | 1245.88 ms | 6.37 ms |
| 8bda0cc+dirty | 1217.90 ms | 1223.02 ms | 5.12 ms |
| e5bc97b+dirty | 1229.17 ms | 1227.64 ms | -1.54 ms |
| 80b2ce3+dirty | 1245.12 ms | 1262.04 ms | 16.92 ms |
| 60ad48c+dirty | 1225.79 ms | 1233.51 ms | 7.72 ms |
| 24cb2a4+dirty | 1241.20 ms | 1232.23 ms | -8.97 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c991c90+dirty | 3.19 MiB | 4.30 MiB | 1.12 MiB |
| 8b86336+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| 22e31b6+dirty | 2.92 MiB | 3.43 MiB | 524.74 KiB |
| 8f0282e+dirty | 3.19 MiB | 4.33 MiB | 1.14 MiB |
| 9385d74+dirty | 2.92 MiB | 3.67 MiB | 772.40 KiB |
| 8bda0cc+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB |
| e5bc97b+dirty | 2.92 MiB | 3.66 MiB | 758.40 KiB |
| 80b2ce3+dirty | 2.92 MiB | 3.40 MiB | 492.75 KiB |
| 60ad48c+dirty | 3.19 MiB | 4.32 MiB | 1.13 MiB |
| 24cb2a4+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB |
antonis
approved these changes
Mar 26, 2025
Contributor
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
LGTM 🚀
This seems to be related with gradle/gradle#9489
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee4aab8 | 418.63 ms | 435.63 ms | 17.01 ms |
| 3f05680 | 397.91 ms | 405.65 ms | 7.74 ms |
| c2a4e9b | 480.42 ms | 485.60 ms | 5.18 ms |
| 2ec71da | 438.14 ms | 460.46 ms | 22.32 ms |
| ae2f6bc | 469.19 ms | 455.58 ms | -13.61 ms |
| 5e5c392 | 390.42 ms | 432.00 ms | 41.58 ms |
| 9dabcce | 485.63 ms | 483.54 ms | -2.09 ms |
| 6e8584e | 447.10 ms | 474.71 ms | 27.61 ms |
| 48ad514 | 454.44 ms | 470.33 ms | 15.89 ms |
| 4cc5c27 | 460.04 ms | 496.32 ms | 36.28 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ee4aab8 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
| 3f05680 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
| c2a4e9b | 17.73 MiB | 20.06 MiB | 2.33 MiB |
| 2ec71da | 17.73 MiB | 20.10 MiB | 2.37 MiB |
| ae2f6bc | 17.75 MiB | 20.11 MiB | 2.37 MiB |
| 5e5c392 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 9dabcce | 17.74 MiB | 20.09 MiB | 2.36 MiB |
| 6e8584e | 17.73 MiB | 19.86 MiB | 2.12 MiB |
| 48ad514 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 4cc5c27 | 17.73 MiB | 19.95 MiB | 2.21 MiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
The Expo CLI uses
--configure-on-demandflag https://github.com/expo/expo/blob/0b739b22bf7ce312cd0399a7147f2f11da7f75ef/packages/@expo/cli/src/start/platforms/android/gradle.ts#L75which causes the tasks created in
gradle.projectsEvaluatedto not be executed.This PR updates the
sentry.gradleto useproject.afterEvaluatewhich executes earlier and this task are correctly registered and executed.💡 Motivation and Context
fixes: #3907
💚 How did you test it?
sample app,
📝 Checklist
sendDefaultPIIis enabled