Removes temporary flags after Cocoa Bump

[antonis]

📢 Type of change

• Bugfix
• New feature
• Enhancement
• Refactoring

Based on #5036

📜 Description

Removes temporary flags after Cocoa Bump and updates the sample app native initialisation example

The fixes in this PR are needed for the Cocoa 8.54 8.55 bump #5036

Also bumps xcode version due to a test failure

💡 Motivation and Context

fixes #5022

💚 How did you test it?

Manual, CI

📝 Checklist

• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
• I updated the docs if needed.
• I updated the wizard if needed.
• All tests passing
• No breaking changes

🔮 Next steps

#skip-changelog

[github-actions]

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	432.08 ms	448.16 ms	16.08 ms
Size	17.75 MiB	19.68 MiB	1.94 MiB

Baseline results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision	Plain	With Sentry	Diff
f9bd7d3	403.74 ms	385.54 ms	-18.20 ms
f139dae	415.36 ms	400.73 ms	-14.63 ms
6c67a16	442.07 ms	454.91 ms	12.84 ms
ba483fc	407.51 ms	398.52 ms	-8.99 ms

App size

Revision	Plain	With Sentry	Diff
f9bd7d3	17.75 MiB	20.15 MiB	2.41 MiB
f139dae	17.75 MiB	20.15 MiB	2.40 MiB
6c67a16	17.75 MiB	20.15 MiB	2.40 MiB
ba483fc	17.75 MiB	20.15 MiB	2.40 MiB

[github-actions]

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	357.13 ms	406.46 ms	49.33 ms
Size	7.15 MiB	8.41 MiB	1.26 MiB

Baseline results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision	Plain	With Sentry	Diff
f139dae+dirty	383.66 ms	389.28 ms	5.62 ms
f9bd7d3+dirty	403.83 ms	442.76 ms	38.92 ms
ba483fc+dirty	432.91 ms	454.14 ms	21.23 ms
6c67a16+dirty	408.86 ms	440.96 ms	32.10 ms

App size

Revision	Plain	With Sentry	Diff
f139dae+dirty	7.15 MiB	8.42 MiB	1.26 MiB
f9bd7d3+dirty	7.15 MiB	8.42 MiB	1.27 MiB
ba483fc+dirty	7.15 MiB	8.42 MiB	1.26 MiB
6c67a16+dirty	7.15 MiB	8.42 MiB	1.26 MiB

[antonis]

I'll need to investigate the CI failure in older RN. From the logs (see below) it might be related to getsentry/sentry-cocoa#5604

Error: reference to property 'videoWriter' in closure requires explicit use of 'self' to make capture semantics explicit
            SentrySDKLog.debug("[Session Replay] Finished video writing, status: \(videoWriter.status)")
                                                                                   ^
Error: reference to property 'videoWriter' in closure requires explicit use of 'self' to make capture semantics explicit
                SentrySDKLog.warning("[Session Replay] Finish writing video failed, reason: \(String(describing: videoWriter.error))")
                                                                                                                 ^
Error: reference to property 'videoWriter' in closure requires explicit use of 'self' to make capture semantics explicit
                SentrySDKLog.warning("[Session Replay] Finish writing video with unknown status, reason: \(String(describing: videoWriter.error))")
                                                                                                                              ^
Error: reference to property 'videoWriter' in closure requires explicit use of 'self' to make capture semantics explicit
                SentrySDKLog.warning("[Session Replay] Finish writing video in unknown state, reason: \(String(describing: videoWriter.error))")
                                                                                                                           ^
Error: reference to property 'videoWriter' in closure requires explicit use of 'self' to make capture semantics explicit
            switch videoWriter.status {
                   ^
Error: reference to property 'outputFileURL' in closure requires explicit use of 'self' to make capture semantics explicit
                        from: outputFileURL,
                              ^
Error: reference to property 'usedFrames' in closure requires explicit use of 'self' to make capture semantics explicit
                        usedFrames: usedFrames,
                                    ^
Error: reference to property 'videoWidth' in closure requires explicit use of 'self' to make capture semantics explicit
                        videoWidth: Int(videoWidth),
                                        ^
Error: reference to property 'videoHeight' in closure requires explicit use of 'self' to make capture semantics explicit
                        videoHeight: Int(videoHeight)
                                         ^
Error: reference to property 'videoWriter' in closure requires explicit use of 'self' to make capture semantics explicit
                completion(.failure(videoWriter.error ?? SentryOnDemandReplayError.errorRenderingVideo))
                                    ^
Error: reference to property 'videoWriter' in closure requires explicit use of 'self' to make capture semantics explicit
                completion(.failure(videoWriter.error ?? SentryOnDemandReplayError.errorRenderingVideo))

[antonis]

It's interesting that the blocking CI failure happens only in dev no-frameworks builds.

The equivalent expo check doesn't fail either 🤔

[Sentry] Compiling SentrySDK.swift
Error: incorrect argument label in call (have 'userFeedback:', expected 'error:')
        SentrySDKInternal.capture(userFeedback: userFeedback)
                                 ^~~~~~~~~~~~~
Error: 'UserFeedback' is not convertible to 'any Error'
        SentrySDKInternal.capture(userFeedback: userFeedback)
                                                ^
Error: Process completed with exit code 65.

It looks like the SDK_V9 behaves different in this configuration https://github.com/getsentry/sentry-cocoa/blob/main/Sources/Swift/Helper/SentrySDK.swift#L251

[antonis]

To facilitate the investigation of the above issue I’ve created a new branch with everything in one commit. This includes the changes in:
#5036
#5038
and should reproduce the issue described here.

[antonis]

The above failed tests passed with an xcode bump 7920e7f