Pass screenshotStrategy option from mobileReplayIntegration to the Android SDK#5808
Merged
Pass screenshotStrategy option from mobileReplayIntegration to the Android SDK#5808
screenshotStrategy option from mobileReplayIntegration to the Android SDK#5808Conversation
…e Android native SDK
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
Contributor
antonis
reviewed
Mar 12, 2026
|
|
||
| if (rnMobileReplayOptions.hasKey("screenshotStrategy")) { | ||
| final String strategy = rnMobileReplayOptions.getString("screenshotStrategy"); | ||
| if ("canvas".equals(strategy)) { |
Contributor
There was a problem hiding this comment.
We can probably do a lowercase conversion similar to the original implementation but I think this is not needed since the passed values from JS are distinct
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Fixes the issue with
screenshotStrategynot being passed correctly.📝 Checklist
sendDefaultPIIis enabled🔮 Next steps