Skip to content

Pass screenshotStrategy option from mobileReplayIntegration to the Android SDK#5808

Merged
alwx merged 2 commits intomainfrom
alwx/fix/rn-sentry-strategy
Mar 12, 2026
Merged

Pass screenshotStrategy option from mobileReplayIntegration to the Android SDK#5808
alwx merged 2 commits intomainfrom
alwx/fix/rn-sentry-strategy

Conversation

@alwx
Copy link
Contributor

@alwx alwx commented Mar 12, 2026

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Fixes the issue with screenshotStrategy not being passed correctly.

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2026

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


  • Pass screenshotStrategy option from mobileReplayIntegration to the Android SDK by alwx in #5808
  • fix(core): Exclude server-only AI/MCP modules from native bundles by antonis in #5802
  • chore(deps): update Cocoa SDK to v9.7.0 by github-actions in #5805
  • chore(deps): update CLI to v3.3.3 by github-actions in #5806
  • Automatically capture a warning event when Expo Updates performs an emergency launch by alwx in #5794
  • fix(core): Improve native init log message clarity by antonis in #5801
  • feat(core): Add environment option to Expo config plugin by antonis in #5796
  • chore(deps): update CLI to v3.3.2 by github-actions in #5799
  • chore(deps): update Maestro to v2.3.0 by github-actions in #5790
  • chore(deps): update JavaScript SDK to v10.43.0 by github-actions in #5791
  • chore(deps): update CLI to v3.3.1 by github-actions in #5793
  • fix(core): Defer initial navigation span creation until navigation container is registered by antonis in #5789
  • Ref(Sample): Add existing bundled playgroundscreen into sample app by lucas-zimerman in #5778
  • Auto tracing for expo-image and expo-asset by alwx in #5718
  • Expo Updates: add tags with Expo Updates context vars to make them searchable/filterable by alwx in #5788
  • chore(deps): bump actions/setup-node from 6.2.0 to 6.3.0 by dependabot in #5784
  • chore(deps): bump github/codeql-action from 4.32.4 to 4.32.6 by dependabot in #5781
  • chore(deps): bump getsentry/craft/.github/workflows/changelog-preview.yml from 2.23.1 to 2.23.2 by dependabot in #5782
  • chore(deps): bump getsentry/craft from 2.21.7 to 2.23.2 by dependabot in #5783
  • chore(deps): bump tar to ^7.5.10 by antonis in #5777

🤖 This preview updates automatically when you update the PR.

@alwx alwx marked this pull request as ready for review March 12, 2026 12:45
@github-actions
Copy link
Contributor

Fails
🚫 Pull request is not ready for merge, please add the "ready-to-merge" label to the pull request

Generated by 🚫 dangerJS against e9eee36

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for catching this @alwx 🙇


if (rnMobileReplayOptions.hasKey("screenshotStrategy")) {
final String strategy = rnMobileReplayOptions.getString("screenshotStrategy");
if ("canvas".equals(strategy)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably do a lowercase conversion similar to the original implementation but I think this is not needed since the passed values from JS are distinct

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alwx alwx merged commit 991892d into main Mar 12, 2026
36 of 46 checks passed
@alwx alwx deleted the alwx/fix/rn-sentry-strategy branch March 12, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants