Skip to content

Add better needs_web check to CI #5863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alwx merged 1 commit into from
Mar 23, 2026
Merged

Add better needs_web check to CI #5863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/detect-changes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ on:
needs_sample_expo:
description: 'Whether the Expo sample app workflow should run'
value: ${{ jobs.changes.outputs.needs_sample_expo }}
needs_web:
description: 'Whether web jobs should run (sample builds)'
value: ${{ jobs.changes.outputs.needs_web }}

jobs:
changes:
Expand All @@ -74,6 +77,7 @@ jobs:
needs_android: ${{ steps.evaluate.outputs.needs_android }}
needs_sample_react_native: ${{ steps.evaluate.outputs.needs_sample_react_native }}
needs_sample_expo: ${{ steps.evaluate.outputs.needs_sample_expo }}
needs_web: ${{ steps.evaluate.outputs.needs_web }}
steps:
- uses: actions/checkout@v4

Expand Down Expand Up @@ -168,3 +172,17 @@ jobs:
echo "needs_sample_expo=false" >> "$GITHUB_OUTPUT"
echo "=> needs_sample_expo=false"
fi

# Web builds run when:
# - JS source changed (the web bundle depends on it)
# - CI config changed (need to validate workflows themselves)
# - Push to main or release branch (always run everything)
if [[ "$JS_SOURCE" == "true" \
|| "$CI_CHANGED" == "true" \
|| "$IS_MAIN_OR_RELEASE" == "true" ]]; then
echo "needs_web=true" >> "$GITHUB_OUTPUT"
echo "=> needs_web=true"
else
echo "needs_web=false" >> "$GITHUB_OUTPUT"
echo "=> needs_web=false"
fi
4 changes: 2 additions & 2 deletions .github/workflows/sample-application-expo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,9 @@ jobs:
elif [[ "${{ matrix.platform }}" == "android" && "${{ needs.detect-changes.outputs.needs_android }}" != "true" ]]; then
echo "skip=true" >> "$GITHUB_OUTPUT"
echo "Skipping Android — no relevant changes detected."
elif [[ "${{ matrix.platform }}" == "web" && "${{ needs.detect-changes.outputs.js_source }}" != "true" ]]; then
elif [[ "${{ matrix.platform }}" == "web" && "${{ needs.detect-changes.outputs.needs_web }}" != "true" ]]; then
echo "skip=true" >> "$GITHUB_OUTPUT"
echo "Skipping Web — no relevant JS changes detected."
echo "Skipping Web — no relevant changes detected."
fi

- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
Expand Down
Loading