chore: Bump Cocoa SDK to 8.54.0
#2265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…y/sentry-unity into chore/cocoa-bump-8.54.0
bitsandfoxes
commented
Aug 4, 2025
| #import <Sentry/PrivateSentrySDKOnly.h> | ||
| #import <Sentry/SentryOptions+HybridSDKs.h> | ||
| #import <Sentry/Sentry.h> | ||
| #import <MetricKit/MetricKit.h> |
Contributor
Author
There was a problem hiding this comment.
I have to add #import <MetricKit/MetricKit.h>. Otherwise it will break in Sentry-Switft.h with
@interface SentryMXManager : NSObject <MXMetricManagerSubscriber> -- No type or protocol named 'MXMetricManagerSubscriber'
vaind
approved these changes
Aug 6, 2025
Contributor
vaind
left a comment
vaind
left a comment
There was a problem hiding this comment.
Is it safe to assume this is properly tested manually and/or in smoke tests?
Contributor
Author
Of course! |
mujacica
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the
SentryOptions+HybridSdkThis PR also addresses the changes of getsentry/sentry-cocoa#5698 where
SentryOptions+HybridSDKs.hmorphed intoSentryOptionsInternal.h.Sample events