fix: Update debug symbol upload for Desktop #2298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@sentry review |
|
🔒 GenAI Consent Required To enable PR review and test generation via Prevent, an organization admin needs to:
Once enabled, you can re-trigger this review by commenting. |
Member
|
bugbot review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
bitsandfoxes
commented
Aug 27, 2025
Comment on lines
+125
to
+127
| // Setting the `buildOutputDir` as the root for debug symbol upload. This will make sure we pick up | ||
| // `BurstDebugInformation` and`_DoNotShip` as well | ||
| var paths = $" \"{buildOutputDir}\""; |
Contributor
Author
There was a problem hiding this comment.
We verify the debug symbol upload happening as part of our smoke testing in CI.
bitsandfoxes
requested review from
a team,
limbonaut,
mujacica,
tustanivsky and
vaind
tustanivsky
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #656, #1602
With this change Sentry CLI will now pick up debug symbols from within
Burstand_DoNotShipdirectories automatically.