Merged
Conversation
kamilogorek
suggested changes
Jul 8, 2022
kamilogorek
approved these changes
Jul 14, 2022
Contributor
Author
|
@kamilogorek and @bruno-garcia If I got it right -> https://classic.yarnpkg.com/en/docs/dependency-versions#toc-caret-ranges |
marandaneto
added a commit
that referenced
this pull request
Jul 21, 2022
This reverts commit c1885d2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix getsentry/sentry-react-native#2267
No need of doing https://docs.sentry.io/platforms/react-native/troubleshooting/#react-native-069-and-higher manually
We should bump a minor 1.3.0 since it's not compatible with RN < 0.69
Next: uninstall steps are broken already even for the current version of RN.
Wondering if we should get rid of the uninstall patches or not.
https://github.com/getsentry/sentry-wizard/pull/66/files Adds
EXTRA_PACKAGER_ARGSbut does not remove it during uninstall steps.It does not unpatch the App.js that calls
Sentry.init.It does not delete the sentry.properties files, but just comment the fields such as
#defaults.org=.