Skip to content

Revert "Revert "Patch React Native xcode RN 0.69""#178

Merged
marandaneto merged 3 commits intomasterfrom
revert-177-revert-173-chore/patch-xcode-rn069
Jul 21, 2022
Merged

Revert "Revert "Patch React Native xcode RN 0.69""#178
marandaneto merged 3 commits intomasterfrom
revert-177-revert-173-chore/patch-xcode-rn069

Conversation

@marandaneto
Copy link
Copy Markdown
Contributor

Reverts #177

Copy link
Copy Markdown
Contributor

@kamilogorek kamilogorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# Unreleased would also do, but we know its 2.0.0 so we can leave it as is.

Also is there nothing else that we could ship with 2.0? It's a good timing to do so.

@marandaneto
Copy link
Copy Markdown
Contributor Author

# Unreleased would also do, but we know its 2.0.0 so we can leave it as is.

Also is there nothing else that we could ship with 2.0? It's a good timing to do so.

https://github.com/getsentry/sentry-wizard/runs/7445675957?check_suite_focus=true failed because of No changelog entry found for version "1.3.1" so I thought that it was necessary for some reason.
The 2.0.0 is a P0 for RN, so we have to do it asap.

@marandaneto marandaneto merged commit e3843e8 into master Jul 21, 2022
@marandaneto marandaneto deleted the revert-177-revert-173-chore/patch-xcode-rn069 branch July 21, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants