feat(remix): Add instrumentation step for Express server adapters. #504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
3 tasks
AbhiPrasad
approved these changes
Dec 6, 2023
Member
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
lets get the changelog conflict updated and we can merge!
onurtemizkan
force-pushed
the
onur/remix-express-instrumentation
branch
from
458704d to
d89a46c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for instrumenting Express server adapters in Remix projects.
Summary:
@remix-run/expressis in the dependency list.createRequestHandlerfunction and updates its usages.buildparameter for the dev mode. (Ref: Type error with Remix+Vite and Express Server sentry-javascript#9500 (comment))