feat(react-native): Improve error reporting for RN Wizard#861
feat(react-native): Improve error reporting for RN Wizard#861
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #861 +/- ##
==========================================
- Coverage 27.46% 27.36% -0.10%
==========================================
Files 130 130
Lines 14274 14411 +137
Branches 855 856 +1
==========================================
+ Hits 3920 3944 +24
- Misses 10336 10449 +113
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # CHANGELOG.md # src/react-native/xcode.ts
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md # src/react-native/xcode.ts
|
The improvements look good and make sense; let's just make sure every time we fail to do something to show copy copy-pastable manual step and |
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md # src/react-native/javascript.ts
|
@antonis Let me know if this ready for another pass, I still see some pending comments, feel free to just add a comment to them or 👍/👎. |
|
Due to possible PII in the stack traces, we can't at the moment capture the errors. |
|
Thank you for your feedback @krystofwoldrich 🙇
I didn't identify more places were manual steps are missing.
Updated with 5fbf440
I removed the stack traces introduced in the commit above with fefeb29 This should be ready for another pass 🙏 |
krystofwoldrich
left a comment
There was a problem hiding this comment.
Looks great! Thank you for adding the extra log and error captures. 🚀
# Conflicts: # CHANGELOG.md
Fixes #841
Description
This PR enhances error handling and logging for the RN Wizard. For this purpose the following files under
src/react-nativewere reviewed:expo-env-file.tsexpo-metro.tsexpo.tsgit.tsglob.tsgradle.tsjavascript.tsmetro.tsoptions.tsreact-native-wizard.tsuninstall.tsxcode.tsNo functional changes were introduced.