Skip to content

feat(react-native): Improve error reporting for RN Wizard#861

Merged
antonis merged 18 commits intomasterfrom
antonis/rn-error-reporting
Apr 28, 2025
Merged

feat(react-native): Improve error reporting for RN Wizard#861
antonis merged 18 commits intomasterfrom
antonis/rn-error-reporting

Conversation

@antonis
Copy link
Contributor

@antonis antonis commented Mar 18, 2025

Fixes #841

Description

This PR enhances error handling and logging for the RN Wizard. For this purpose the following files under src/react-native were reviewed:

  • expo-env-file.ts
  • expo-metro.ts
  • expo.ts
  • git.ts
  • glob.ts
  • gradle.ts
  • javascript.ts
  • metro.ts
  • options.ts
  • react-native-wizard.ts
  • uninstall.ts
  • xcode.ts

No functional changes were introduced.

@github-actions
Copy link

github-actions bot commented Mar 18, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against f016ec1

@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 14.59459% with 158 lines in your changes missing coverage. Please review.

Project coverage is 27.36%. Comparing base (7f5e924) to head (f016ec1).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/react-native/metro.ts 2.00% 49 Missing ⚠️
src/react-native/xcode.ts 15.55% 38 Missing ⚠️
src/react-native/javascript.ts 0.00% 20 Missing ⚠️
src/react-native/expo-metro.ts 20.83% 19 Missing ⚠️
src/react-native/gradle.ts 15.38% 11 Missing ⚠️
src/react-native/glob.ts 16.66% 10 Missing ⚠️
src/react-native/expo-env-file.ts 0.00% 7 Missing ⚠️
src/react-native/expo.ts 71.42% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #861      +/-   ##
==========================================
- Coverage   27.46%   27.36%   -0.10%     
==========================================
  Files         130      130              
  Lines       14274    14411     +137     
  Branches      855      856       +1     
==========================================
+ Hits         3920     3944      +24     
- Misses      10336    10449     +113     
  Partials       18       18              
Flag Coverage Δ
unit-tests 27.36% <14.59%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@antonis antonis marked this pull request as ready for review March 18, 2025 14:29
@antonis antonis requested a review from krystofwoldrich March 18, 2025 14:29
# Conflicts:
#	CHANGELOG.md
#	src/react-native/xcode.ts
@krystofwoldrich
Copy link
Contributor

The improvements look good and make sense; let's just make sure every time we fail to do something to show copy copy-pastable manual step and Sentry.captureExption('Error desc without PII').

@antonis antonis requested a review from krystofwoldrich April 17, 2025 14:07
@krystofwoldrich
Copy link
Contributor

@antonis Let me know if this ready for another pass, I still see some pending comments, feel free to just add a comment to them or 👍/👎.

@krystofwoldrich
Copy link
Contributor

Due to possible PII in the stack traces, we can't at the moment capture the errors.

@antonis
Copy link
Contributor Author

antonis commented Apr 24, 2025

Thank you for your feedback @krystofwoldrich 🙇

let's just make sure every time we fail to do something to show copy copy-pastable manual step

I didn't identify more places were manual steps are missing.

and Sentry.captureExption('Error desc without PII').

Updated with 5fbf440

Due to possible PII in the stack traces, we can't at the moment capture the errors.

I removed the stack traces introduced in the commit above with fefeb29

This should be ready for another pass 🙏

Copy link
Contributor

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for adding the extra log and error captures. 🚀

@antonis antonis merged commit f938480 into master Apr 28, 2025
42 of 44 checks passed
@antonis antonis deleted the antonis/rn-error-reporting branch April 28, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve error reporting for RN Wizard

2 participants