feat(Mobile): adds sendDefaultPii to Mobile wizards#981
Merged
Conversation
added 7 commits
May 2, 2025 14:47
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #981 +/- ##
=======================================
Coverage 27.36% 27.36%
=======================================
Files 130 130
Lines 14411 14411
Branches 856 856
=======================================
Hits 3944 3944
Misses 10449 10449
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced May 2, 2025
kahest
commented
May 2, 2025
| options.debug = true // Enabled debug when first installing is always helpful | ||
|
|
||
| // Adds IP for users. | ||
| // For more information, visit: https://docs.sentry.io/platforms/apple/data-management/data-collected/ |
Contributor
Author
There was a problem hiding this comment.
Note: I also opened a docs PR to tell users that the data collected varies depending on platform
philipphofmann
approved these changes
May 5, 2025
Member
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
LGTM, with two minor suggestions.
buenaflor
approved these changes
May 5, 2025
Lms24
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sendDefaultPii=trueto Mobile wizards:Note: as mentioned in #955 (comment) we set the default value of
trueand link to the relevant docs pagefixes #790
fixes #956
(Flutter + RN don't have GH issues for this)