Conversation
| # TODO: Replace with Gcloud download | ||
| # Download coverage artifact from a previous workflow run | ||
| # actions/download-artifact doesn't support cross-run downloads, so we use alternatives | ||
| - name: Download coverage database from run 20529759656 |
There was a problem hiding this comment.
Working on the main branch upload and I can handle swapping this for Gcloud download in the future
There was a problem hiding this comment.
I think we'll need to keep this around for the stock backend-test workflow. Might be best to leave this in and we can leverage this for both backend.yml and backend_selective_testing - in this case we can pass the selected_tests from the select-tests.py as an arg to this, or just a None/empty array if backend.yml (all tests)
There was a problem hiding this comment.
i was thinking we don't need dynamic sharding for the old backend workflow
we need to hardcode it back to 22 in main and remove this in a separate pr
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
improved version of #105500
also you can test test selection and dynamic shard count locally with something like
COVERAGE_DB_PATH=~/Downloads/.coverage.combined GITHUB_PR_BASE_REF=a237e1e8676f5ed76a2efde1b649e9aecf85fe52 python scripts/select-tests.py