feat(onboarding): Added Metrics to Unity#108118
Conversation
| ...(params.isMetricsSelected | ||
| ? ([ | ||
| { | ||
| title: t('Metrics'), | ||
| content: [metricsVerify(params)], | ||
| }, | ||
| ] satisfies OnboardingStep[]) | ||
| : []), |
There was a problem hiding this comment.
hmm I believe it is better to add Metrics under the Verify section instead of introducing an additional header.
Screen.Recording.2026-02-24.at.08.50.55.mov
|
|
||
| import docs from '.'; | ||
|
|
||
| describe('metrics', () => { |
There was a problem hiding this comment.
it seems that you are missing a API call mock for GET /projects/org-slug/project-slug/ and that is why your tests are failing.
|
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Wrong import style: default instead of named import
- Changed from default import to named import
import {docs} from '.'to match the export in unity/index.tsx.
- Changed from default import to named import
Or push these changes by commenting:
@cursor push f29e94f9a8
Preview (f29e94f9a8)
diff --git a/static/app/gettingStartedDocs/unity/metrics.spec.tsx b/static/app/gettingStartedDocs/unity/metrics.spec.tsx
--- a/static/app/gettingStartedDocs/unity/metrics.spec.tsx
+++ b/static/app/gettingStartedDocs/unity/metrics.spec.tsx
@@ -6,7 +6,7 @@
import {ProductSolution} from 'sentry/components/onboarding/gettingStartedDoc/types';
-import docs from '.';
+import {docs} from '.';
function renderMockRequests() {
MockApiClient.addMockResponse({This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
|
|
||
| import {ProductSolution} from 'sentry/components/onboarding/gettingStartedDoc/types'; | ||
|
|
||
| import docs from '.'; |
There was a problem hiding this comment.
Wrong import style: default instead of named import
Medium Severity
import docs from '.' uses a default import, but unity/index.tsx only has a named export (export const docs). Every other test file in gettingStartedDocs correctly uses import {docs} from '.'. With the bundler's module interop, the default import would resolve to the module namespace object (e.g. { docs: {…} }) rather than the Docs object itself, causing renderWithOnboardingLayout to receive a wrongly-shaped config and the tests to fail or pass vacuously.



Following what happened in #106551
The docs have been merged with getsentry/sentry-docs#16356