Skip to content

feat(onboarding): Added Metrics to Unity#108118

Open
bitsandfoxes wants to merge 6 commits intomasterfrom
feat/unity-metrics
Open

feat(onboarding): Added Metrics to Unity#108118
bitsandfoxes wants to merge 6 commits intomasterfrom
feat/unity-metrics

Conversation

@bitsandfoxes
Copy link
Contributor

Following what happened in #106551
The docs have been merged with getsentry/sentry-docs#16356

@bitsandfoxes bitsandfoxes requested a review from a team as a code owner February 12, 2026 13:55
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Feb 12, 2026
Comment on lines +130 to +137
...(params.isMetricsSelected
? ([
{
title: t('Metrics'),
content: [metricsVerify(params)],
},
] satisfies OnboardingStep[])
: []),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I believe it is better to add Metrics under the Verify section instead of introducing an additional header.

Screen.Recording.2026-02-24.at.08.50.55.mov


import docs from '.';

describe('metrics', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems that you are missing a API call mock for GET /projects/org-slug/project-slug/ and that is why your tests are failing.

@getsantry
Copy link
Contributor

getsantry bot commented Mar 18, 2026

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Mar 18, 2026
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Wrong import style: default instead of named import
    • Changed from default import to named import import {docs} from '.' to match the export in unity/index.tsx.

Create PR

Or push these changes by commenting:

@cursor push f29e94f9a8
Preview (f29e94f9a8)
diff --git a/static/app/gettingStartedDocs/unity/metrics.spec.tsx b/static/app/gettingStartedDocs/unity/metrics.spec.tsx
--- a/static/app/gettingStartedDocs/unity/metrics.spec.tsx
+++ b/static/app/gettingStartedDocs/unity/metrics.spec.tsx
@@ -6,7 +6,7 @@
 
 import {ProductSolution} from 'sentry/components/onboarding/gettingStartedDoc/types';
 
-import docs from '.';
+import {docs} from '.';
 
 function renderMockRequests() {
   MockApiClient.addMockResponse({

This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.


import {ProductSolution} from 'sentry/components/onboarding/gettingStartedDoc/types';

import docs from '.';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong import style: default instead of named import

Medium Severity

import docs from '.' uses a default import, but unity/index.tsx only has a named export (export const docs). Every other test file in gettingStartedDocs correctly uses import {docs} from '.'. With the bundler's module interop, the default import would resolve to the module namespace object (e.g. { docs: {…} }) rather than the Docs object itself, causing renderWithOnboardingLayout to receive a wrongly-shaped config and the tests to fail or pass vacuously.

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants