feat(workflow_engine): Only link workflows to the IssueStream by saponifi3d · Pull Request #112276 · getsentry/sentry

saponifi3d · 2026-04-06T18:58:08Z

Description

Update the on project creation to only link to the issue stream detector, rather than the issue stream and error detectors.

Moves the code into workflow_engine to keep things organized.

src/sentry/workflow_engine/defaults/workflows.py

src/sentry/projects/project_rules/creator.py

src/sentry/workflow_engine/defaults/workflows.py

created a `defaults/workflows.py` so we can separate the signal handlers and the default creation code.

src/sentry/workflow_engine/defaults/workflows.py

saponifi3d · 2026-04-07T05:18:30Z

src/sentry/workflow_engine/defaults/workflows.py

+    if existing:
+        return existing
+
+    with transaction.atomic(router.db_for_write(Workflow)):


#todo - might be nice to provide a helper to create workflows in the future.

src/sentry/workflow_engine/defaults/workflows.py

kcons · 2026-04-07T20:11:21Z

(still reviewing)

kcons

LG, but a few notes on things that confused me.

kcons · 2026-04-07T20:36:53Z

src/sentry/workflow_engine/migration_helpers/issue_alert_migration.py

                project=self.project,
                defaults={"config": {}, "name": ERROR_DETECTOR_NAME},
            )
            AlertRuleDetector.objects.get_or_create(detector=error_detector, rule_id=self.rule.id)


do we still want to do this?

i believe so - this code is really to setup the references on the legacy tables, and i think we'd need all these references until we are no longer dual writing in the API.

kcons · 2026-04-07T20:38:37Z

src/sentry/workflow_engine/migration_helpers/issue_alert_migration.py

+                workflow=workflow,
+            )
+            for detector in default_detectors
+            if detector.type != ErrorGroupType.slug


maybe _create_detector_lookups shouldn't return the error detector if we're not trying to associate with it?

kcons · 2026-04-07T20:38:45Z

src/sentry/workflow_engine/migration_helpers/issue_alert_migration.py

+
+        DetectorWorkflow.objects.bulk_create(
+            references_to_create,
+            ignore_conflicts=True,


curious; why?

Crons. Crons creates all their workflows / alerts through this layer, so there may be cases where they are already created / have the connection. if i don't ignore_conflicts there's an edge case that those cause 💥

kcons · 2026-04-07T20:43:07Z

tests/sentry/workflow_engine/migration_helpers/test_issue_alert_migration.py


-        error_detector_workflow = DetectorWorkflow.objects.get(detector=error_detector)
-        assert error_detector_workflow.workflow == workflow
+        assert not DetectorWorkflow.objects.filter(detector=error_detector).exists()


Seems like maybe this assert method can go away, or maybe needs to be renamed?
assert_issue_stream_detector_migrated covers the issue stream presence/existence, and I'm not sure we need to verify that an error detector exists and has specific values in order to check it isn't associated.

… that

sentry · 2026-04-07T23:24:11Z

src/sentry/workflow_engine/defaults/workflows.py

+) -> Sequence[DetectorWorkflow]:
+    # Because we don't know if this signal is handled already or not...
+    issue_stream_detector = _ensure_detector(project, IssueStreamGroupType.slug)
+


Bug: An UnableToAcquireLockApiError in ensure_default_workflows is silently swallowed by send_robust(), causing workflow creation to fail without any logging or alerts.
_{Severity: MEDIUM}

Suggested Fix

Wrap the call to _ensure_detector within ensure_default_workflows in a try/except block. Explicitly catch the UnableToAcquireLockApiError, log a warning, and capture the exception to Sentry for visibility, similar to the pattern used in project_detectors.py.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not valid. Location: src/sentry/workflow_engine/defaults/workflows.py#L28-L31 Potential issue: The `ensure_default_workflows` function, called via the `project_created` signal, can raise an `UnableToAcquireLockApiError` if it fails to acquire a lock when creating a detector. Because the signal is dispatched using `send_robust()`, this exception is silently swallowed without any logging or error handling. This results in a silent failure where the default workflow is not created for the new project, and there is no visibility into the failure, making it difficult to debug in production.

# Description Since these workflows are connected to both the Issue Stream and the Error detector, we can remove the connection to the error detector because it's a subset of the Issue Stream. This PR will find where this redundant connection is occurring, and remove the relationship for the Error Detector, while preserving it. We don't need to make any processing changes etc, because of how these are selected in `processors/worfklow.py` This PR should only be merged after: #112276 so we don't add any new connections after migrating.

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 6, 2026

vercel bot deployed to Preview April 6, 2026 19:21 View deployment

saponifi3d force-pushed the jcallender/aci/organize-rule-defaults branch 2 times, most recently from 9e8cb89 to d1ae9bb Compare April 6, 2026 19:23

saponifi3d force-pushed the jcallender/aci/organize-defaults-code branch from 682bf2a to 2f3a48c Compare April 6, 2026 19:24

saponifi3d force-pushed the jcallender/aci/organize-rule-defaults branch from d1ae9bb to f146ca8 Compare April 6, 2026 19:24

saponifi3d changed the title ~~Jcallender/aci/organize rule defaults~~ ref(workflow_engine): Normalize the Workflow creation for a new project Apr 6, 2026

vercel bot deployed to Preview April 6, 2026 19:26 View deployment

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview April 6, 2026 19:39 View deployment

vercel bot deployed to Preview April 6, 2026 19:47 View deployment

vercel bot deployed to Preview April 6, 2026 20:26 View deployment

vercel bot deployed to Preview April 6, 2026 20:53 View deployment

Base automatically changed from jcallender/aci/organize-defaults-code to master April 6, 2026 22:00

saponifi3d force-pushed the jcallender/aci/organize-rule-defaults branch from aa02f39 to 7659b1a Compare April 6, 2026 22:14

vercel bot deployed to Preview April 6, 2026 22:16 View deployment

sentry-warden bot reviewed Apr 6, 2026

View reviewed changes

src/sentry/workflow_engine/defaults/workflows.py Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview April 6, 2026 22:41 View deployment

This comment was marked as outdated.

Sign in to view

getsentry deleted a comment from github-actions bot Apr 6, 2026

saponifi3d force-pushed the jcallender/aci/organize-rule-defaults branch from 1783511 to d5af62d Compare April 6, 2026 23:01

vercel bot deployed to Preview April 6, 2026 23:03 View deployment

sentry-warden bot reviewed Apr 6, 2026

View reviewed changes

src/sentry/projects/project_rules/creator.py Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

vercel bot deployed to Preview April 6, 2026 23:19 View deployment

sentry-warden bot reviewed Apr 6, 2026

View reviewed changes

src/sentry/workflow_engine/defaults/workflows.py Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

saponifi3d requested review from a team as code owners April 7, 2026 16:43

saponifi3d requested a review from kcons April 7, 2026 16:43

saponifi3d force-pushed the jcallender/aci/organize-rule-defaults branch from 014e847 to 12683dc Compare April 7, 2026 17:20

saponifi3d added 8 commits April 7, 2026 10:20

Move the receivers/rules.py to receivers/project_workflows.py and

b99f6ff

created a `defaults/workflows.py` so we can separate the signal handlers and the default creation code.

ensure the project workflow is registered correctly

4081c33

find / fix a few more places where receviers.rules was being referenced.

62d3b09

fix remaining mypy issues

bca4728

set the action interval to 0 by default on the default workflow

3095966

Make sure the data condition groups have the org associated

1f5b8ff

Fix some tests and make general improvements

ab791ab

minor cleanup / info from a bot review

b4286e1

vercel bot deployed to Preview April 7, 2026 17:21 View deployment

sentry bot reviewed Apr 7, 2026

View reviewed changes

src/sentry/workflow_engine/defaults/workflows.py Show resolved Hide resolved

saponifi3d commented Apr 7, 2026

View reviewed changes

saponifi3d mentioned this pull request Apr 7, 2026

ref(aci): Remove redundant DetectorWorkflow rows #112402

Merged

kcons approved these changes Apr 7, 2026

View reviewed changes

Only return the detectors to connect, rather than all created detectors.

c986a48

saponifi3d force-pushed the jcallender/aci/organize-rule-defaults branch from 12683dc to c986a48 Compare April 7, 2026 22:33

vercel bot deployed to Preview April 7, 2026 22:35 View deployment

Add a comment to make it clearer that we're doing the .exists and all…

af6d9d9

… that

saponifi3d enabled auto-merge (squash) April 7, 2026 23:20

vercel bot deployed to Preview April 7, 2026 23:22 View deployment

sentry bot reviewed Apr 7, 2026

View reviewed changes

saponifi3d merged commit 7a341a7 into master Apr 7, 2026
76 checks passed

saponifi3d deleted the jcallender/aci/organize-rule-defaults branch April 7, 2026 23:38

Uh oh!

Conversation

saponifi3d commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

saponifi3d Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kcons commented Apr 7, 2026

Uh oh!

kcons left a comment

Choose a reason for hiding this comment

Uh oh!

kcons Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

saponifi3d Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

kcons Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

kcons Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

saponifi3d Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kcons Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

sentry bot Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

saponifi3d commented Apr 6, 2026 •

edited

Loading

saponifi3d Apr 7, 2026 •

edited

Loading