ref(plugins): migrate plugin config to BackendJsonSubmitForm#112340
Draft
priscilawebdev wants to merge 1 commit intotkdodo/ref/de-1052-externalissues-to-backendformadapterfrom
Draft
Conversation
Replace the legacy PluginSettings class component and GenericField rendering with BackendJsonSubmitForm for plugin configuration forms. The plugin config now fetches field definitions via useApiQuery and maps backend field types to the new form adapter, eliminating the dependency on the client-side plugin module system for settings. Refs DE-1054 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the project-level plugin configuration forms from the legacy
PluginSettingsclass component +GenericFieldrendering to the newBackendJsonSubmitFormadapter.PluginConfignow fetches field definitions directly viauseApiQueryfrom
GET /projects/{org}/{project}/plugins/{id}/and maps the backendfield types (
bool→boolean,readonly→disabled, etc.) to theJsonFormAdapterFieldConfigshape. This removes the dependency on theclient-side plugin module system (
plugins.get(plugin).renderSettings())for rendering settings.
Stacked on #112094 which adds
BackendJsonSubmitForm.Notable behavioral changes:
UIs that are replaced with a flat form. Both plugins are deprecated with
first-party integration replacements available.
Refs DE-1054