ref(nav): use topbar slot for headeractions#112449
Open
Conversation
Plan for migrating action buttons from Layout.HeaderActions (and styled equivalents) into TopBar.Slot name="actions" when the page frame feature flag is active. Covers 28 tasks across three patterns (actions-only, actions+FeedbackButton, actions+FeedbackButton with custom options) plus two component-level migrations (WorkflowEngineListLayout, DomainViewHeader) that cover ~10 additional callers automatically. Co-Authored-By: Claude <noreply@anthropic.com>
When the page frame feature flag is active, move action buttons out of Layout.HeaderActions (and styled equivalents) and into the TopBar via the actions and feedback slots. This gives the TopBar ownership of button placement in the new page frame layout. Covers 28 sites across alerts, dashboards, discover, explore, insights, performance, profiling, preprod, releases, replays, and issue views. Component-level migrations in WorkflowEngineListLayout and DomainViewHeader cover their downstream callers automatically. Co-Authored-By: Claude <noreply@anthropic.com>
Buttons inside TopBar.Slot name="actions" are wrapped by SizeProvider in the TopBar, so explicit size props are redundant. Remove them from the slot branch across all 15 affected files; the else branches (inside Layout.HeaderActions) retain their size props unchanged. Co-Authored-By: Claude <noreply@anthropic.com>
The IssueViewsHeader uses a custom Flex justify="between" layout that co-locates actions (realtime toggle, star, edit menu) with the title in HeaderContent rather than in Layout.HeaderActions. When the page frame feature is active, split the two concerns: title stays in HeaderContent, actions move to TopBar.Slot name="actions". Co-Authored-By: Claude <noreply@anthropic.com>
…pageframe branch Buttons in the TopBar slot already receive size via SizeProvider context. The else branch should match the same prop-less style for consistency.
…ranch The button relies on SizeProvider context from TopBar, but portal-based slots don't propagate context from the outlet's vdom position. Add explicit size prop to match IssueViewStarButton and IssueViewEditMenu until DE-1079 is resolved. Co-Authored-By: Claude Sonnet 4 <noreply@example.com>
Plan has been executed and is no longer needed. Co-Authored-By: Claude Sonnet 4 <noreply@example.com>
github-actions
bot
added
the
Scope: Frontend
JonasBa
changed the title
The no-default-exports eslint rule flagged the default export introduced in this file. Convert to a named export and update the import site. Co-Authored-By: Claude Sonnet 4 <noreply@example.com>
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…branch Co-authored-by: Jonas <JonasBa@users.noreply.github.com>
Co-authored-by: Jonas <JonasBa@users.noreply.github.com>
Resolve conflicts by keeping feedback button in TopBar.Slot name="feedback" and actions in TopBar.Slot name="actions". Adopt helper consts introduced in master (userFeedbackFeedbackOptions, logsFeedbackOptions, issueViewsFeedbackOptions, buildDetailsFeedbackOptions) to reduce inline duplication. Also remove duplicate hasPageFrameFeature declarations introduced during the merge in feedbackListPage, issueViewsList, and buildDetailsHeaderContent. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
createPortal does not propagate React context, so buttons inside TopBar.Slot name="actions" do not inherit the SizeProvider size="sm" wrapping the slot outlet. Add explicit size="sm" to all Button, LinkButton, CreateAlertButton, StatusToggleButton, and NewMonitorButton instances placed inside actions slots across affected views. Co-Authored-By: Claude Sonnet 4.6 <noreply@example.com>
Two files had the hook called twice due to merge conflicts, causing TS2451 redeclaration errors in the @typescript/native-preview CI check. Co-Authored-By: Claude Sonnet 4.6 <noreply@example.com>
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9df0880. Configure here.
| {rule.status === 'disabled' ? t('Edit to enable') : t('Edit Rule')} | ||
| </LinkButton> | ||
| </Grid> | ||
| </Layout.HeaderActions> |
Contributor
There was a problem hiding this comment.
Missing size="sm" on LinkButtons in TopBar slot
Medium Severity
The two LinkButton elements (Duplicate and Edit Rule) inside the TopBar.Slot branch are missing size="sm", while the non-pageframe branch correctly includes it. Because the slot uses createPortal, the SizeProvider size="sm" in the TopBar outlet does not propagate context to slotted content (the PR description itself notes this as DE-1079). These buttons will render at default md size instead of sm, which is inconsistent with every other view in this same PR where size="sm" is kept on buttons inside TopBar.Slot.
Reviewed by Cursor Bugbot for commit 9df0880. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates action buttons from
Layout.HeaderActions(and inline styled equivalents) into theTopBar.Slot name="actions"slot across 28 views, so they render in the unified TopBar when the page frame feature flag is active.Changes
Layout.HeaderActions/Layout.HeaderContentaction patterns with<TopBar.Slot name="actions">across 28 viewssizeprops from buttons inside the slot (they were previously needed to override defaults; now consistent withsmcontext)IssueViewsHeaderwhich was missingsize="sm"in the pageframe branch — explicit prop required until DE-1079 (Slot API context propagation) is resolvedFixes DE-1068