feat(feature-showcase): Redesign and rewrite FeatureTourModal as FeatureShowcase#112532
feat(feature-showcase): Redesign and rewrite FeatureTourModal as FeatureShowcase#112532
Conversation
static/app/views/projectDetail/missingFeatureButtons/missingPerformanceButtons.tsx
Outdated
Show resolved
Hide resolved
static/app/views/projectDetail/missingFeatureButtons/missingReleasesButtons.tsx
Outdated
Show resolved
Hide resolved
Add a new FeatureShowcase component with tests and documentation. This is a compound component replacement for the modal-based FeatureTourModal, designed for inline feature showcases.
42fa7a4 to
f7040e6
Compare
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f7040e6. Configure here.
|
@saponifi3d went ahead and updated this PR so that it only adds the new component, will open a followup PR with the rest. |
saponifi3d
left a comment
There was a problem hiding this comment.
:woohoo: code looks good once the couple of failing tests are address 🙏

Ref ISWF-2160
We need to use a multi-step modal to demo the new Monitors/Alerts product, and we do already have
FeatureTourModalwhich does that and is used in a few hard-to-find places. However, that modal is a bit outdated design-wise and doesn't have the most flexible API (and is a class component).I decided to rewrite it, and to rename it
FeatureShowcase(so that it will not be confused with the existingTourcompoent).FeatureShowcase is a compound component, and the usage is like so (you can also see this in the story file):
See Figma designs here (though I could not match precisely due to the default modal padding being quite large).
Before:
After: