feat(insights): Remove Projects from Insights navigation#112535
feat(insights): Remove Projects from Insights navigation#112535
Conversation
…low-engine-ui flag Move Projects out of the Insights sidebar into their own standalone secondary navigation, accessible from the logo nav at /projects/. When the workflow-engine-ui flag is enabled, /projects/ serves content directly and /insights/projects/ redirects back. Extract shared ProjectsNavigationItems component to deduplicate the "All Projects" link and starred projects list between both sidebars. Refs DAIN-1468 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
Remove the /insights/projects/ test case from the route inference table since projects now have their own nav group with no primary nav button. Co-Authored-By: Claude <noreply@anthropic.com>
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit baa4036. Configure here.
|
|
||
| const redirectPath = organization.features.includes('workflow-engine-ui') | ||
| ? reverseRedirect | ||
| : forwardRedirect; |
There was a problem hiding this comment.
Spurious redirect warning logged on canonical project URLs
Medium Severity
Unconditionally calling both useRedirectNavigationV2Routes hooks causes the internally-fired useLogUnexpectedNavigationRedirect to log false 'Unexpected navigation redirect' warnings to Sentry. This occurs when the discarded hook's oldPathPrefix matches the current canonical URL, generating monitoring noise that may obscure legitimate issues.
Reviewed by Cursor Bugbot for commit baa4036. Configure here.
There was a problem hiding this comment.
This is somewhat of a bummer but doesn't feel that important? Not sure! It's a very rare situation that we have two of those redirect hook in the same place, due to this conditional redirect!
| oldPathPrefix: '/projects/', | ||
| newPathPrefix: '/insights/projects/', | ||
| }); | ||
| const reverseRedirect = useRedirectNavigationV2Routes({ |
There was a problem hiding this comment.
@JonasBa you were trying to remove this redirect hook - do you think we should use something else for this particular behavior?
2 participants
The much beleaguered "Projects" page is being slowly shuffled out. Here's the current (strange) state:
/insights/projects, we moved them there from their old home at/projectsThe Product™ has decided that the "Projects" page and the actual per-project pages are not wanted anymore. The use-case for them is better covered with Dashboards and/or Project Settings in the sidebar, we even added some analytics about it.
Since the sidebar is getting a big shuffle in the near future when "Monitors" appears, we'll also take that opportunity to remove "Projects" from the Insights secondary menu. (We're actually going to remove "Insights" menu completely, but one things at a time). Things are still a bit weird, but it's an intermediate state we're okay with for now. Soon, we will delete these pages altogether, but for now:
/projects/./insights/projects/now redirects to/projects//projects/what would show up there? Now it has the list of pinned projects, which is helpfulThis is all gated behind the Workflow UI flag since we're going to roll out with them!
e.g.,