Skip to content

feat(traces): Use new stack trace in trace drawer #112557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
scttcper wants to merge 1 commit into
base: master
Choose a base branch
from
+22 −2
Draft

feat(traces): Use new stack trace in trace drawer #112557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions ...pp/views/performance/newTraceDetails/traceDrawer/details/transaction/sections/entries.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {Message} from 'sentry/components/events/interfaces/message';
import {StackTrace} from 'sentry/components/events/interfaces/stackTrace';
import {Template} from 'sentry/components/events/interfaces/template';
import {Threads} from 'sentry/components/events/interfaces/threads';
import {IssueStackTrace} from 'sentry/components/stackTrace/issueStackTrace';
import {t} from 'sentry/locale';
import {
EntryType,
Expand All @@ -16,6 +17,8 @@ import {
type EventTransaction,
} from 'sentry/types/event';
import type {Project} from 'sentry/types/project';
import {isNativePlatform} from 'sentry/utils/platform';
import {useOrganization} from 'sentry/utils/useOrganization';
import {InterimSection} from 'sentry/views/issueDetails/streamline/interimSection';

type EventEntryContentProps = {
Expand All @@ -25,9 +28,20 @@ type EventEntryContentProps = {
};

function EventEntryContent({entry, projectSlug, event}: EventEntryContentProps) {
const organization = useOrganization();
const shouldUseNewStackTrace =
organization.features.includes('issue-details-new-stack-trace') &&
!isNativePlatform(event.platform);

switch (entry.type) {
case EntryType.EXCEPTION:
return (
return shouldUseNewStackTrace ? (
<IssueStackTrace
event={event}
values={entry.data.values ?? []}
projectSlug={projectSlug}
/>
) : (
<Exception
event={event}
group={undefined}
Expand All @@ -41,7 +55,13 @@ function EventEntryContent({entry, projectSlug, event}: EventEntryContentProps)
return <Message event={event} data={entry.data} />;

case EntryType.STACKTRACE:
return (
return shouldUseNewStackTrace ? (
<IssueStackTrace
event={event}
stacktrace={entry.data}
projectSlug={projectSlug}
/>
) : (
<StackTrace
event={event}
data={entry.data}
Expand Down
Loading