feat(profiling): New stack trace in span profile details#112559
Open
feat(profiling): New stack trace in span profile details#112559
Conversation
`StackTraceProvider` was applying `maxDepth` to both `allRows` (the full frame list used as the render loop) and `rows` (the filtered visible frames). Since `allRows` includes all system frames and `rows` only includes in-app frames, `maxDepth` would slice different ranges and the intersection could lose in-app frames entirely. Fix: only apply `maxDepth` to `rows`. `allRows` drives the render loop but frames outside `rows` are either null or Activity-hidden, so visible count is still capped. Also uses the new stack trace in the "Most Frequent Stacks in this Span" section behind `issue-details-new-stack-trace`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the new stack trace component in the "Most Frequent Stacks in this Span" section, gated behind
issue-details-new-stack-trace.Also fixes a bug where
maxDepthwas applied to bothallRowsandrowsinStackTraceProvider. SinceallRowsincludes all system frames androwsonly includes visible (in-app) frames, slicing both independently could lose in-app frames when system frames dominate the end of the stack.before
after
