ref(cmdk): Merge CMDKGroup and CMDKAction into single CMDKAction component

[JonasBa]

Changes

Merges CMDKGroup and CMDKAction into a single CMDKAction component. The distinction between the two was artificial — a node becomes a group simply by having children registered under it, which is already documented in the CMDKActionData type comment. Keeping them separate contradicted that stated design intent.

The merged CMDKAction covers all four cases:

Usage	How
Navigation	<CMDKAction display={...} to="/path/" />
Callback	<CMDKAction display={...} onAction={fn} />
Group with children	<CMDKAction display={...}><CMDKAction .../></CMDKAction>
Async resource group	<CMDKAction display={...} resource={queryFn}>{data => ...}</CMDKAction>

CMDKActionDataTo.to is widened from string to LocationDescriptor to match CommandPaletteAsyncResult and the existing callsites.

[sentry]

Bug: The CMDKAction component silently ignores the onAction prop if the to prop is also provided, due to a loss of type-level mutual exclusivity.
_{Severity: MEDIUM}

Suggested Fix

Restore the type-level safety by using a discriminated union for the CMDKActionProps type. This will enforce that either to or onAction can be provided, but not both, preventing this issue at compile time. This was the behavior in the previous version of the component.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: static/app/components/commandPalette/ui/cmdk.tsx#L88-L94

Potential issue: The `CMDKAction` component's props interface was changed from a
discriminated union to a single interface with optional `to` and `onAction` props. This
removes the compile-time guarantee that only one can be provided. The component's
implementation prioritizes the `to` prop for navigation. If a developer provides both
`to` and `onAction` on the same component, the `onAction` callback will be silently
ignored, and only the navigation will occur. This is a type safety regression that could
lead to unexpected behavior where a developer's intended action does not execute.

_{Did we get this right? 👍 / 👎 to inform future reviews.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit c85059a. Configure here.}

[cursor]

Leaf actions unnecessarily subscribe to query state

Medium Severity

The merged CMDKAction unconditionally calls useCommandPaletteState() and useQuery() for every instance, including leaf actions that have no resource and no children. Previously, leaf CMDKAction was lightweight (register + return null). Now every leaf subscribes to the query context, causing all leaf actions to re-render on every keystroke in the palette. With dozens of static leaves plus dynamic ones (projects, settings), this is a meaningful regression in a typing-heavy interaction.

 

^{Reviewed by Cursor Bugbot for commit c85059a. Configure here.}