feat(cra-metrics): Updates subscription deletion #30432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmedetefy
changed the title
ahmedetefy
requested review from
jjbayer and
untitaker
and removed request for
a team
jjbayer
approved these changes
Dec 7, 2021
wedamija
approved these changes
Dec 7, 2021
Member
wedamija
left a comment
wedamija
left a comment
There was a problem hiding this comment.
lgtm, are the test failures just because the endpoint isn't ready on the snuba side yet?
| QueryDatasets.TRANSACTIONS: EntityKey.Transactions, | ||
| }[dataset] | ||
| # If we get to this, then dataset must be either the metrics or the sessions datasets | ||
| except KeyError: |
Member
There was a problem hiding this comment.
Using KeyError feels a bit weird here. Would we better defining the mapping outside and for all entities/datasets, then doing:
entity_key = entity_key_mapping[dataset]
if entity_key in [EntityKey.MetricsCounters, EntityKey.Sessions]:
# Do extra error checking
return entity_key
Contributor
Author
There was a problem hiding this comment.
Yeah you are right!
ahmedetefy
force-pushed
the
cra-metrics/create-metrics-cra
branch
2 times, most recently
from
abb1dae to
c27bbea
Compare
ahmedetefy
force-pushed
the
cra-metrics/delete-metrics-cra
branch
from
c9be496 to
e9552bd
Compare
Contributor
Author
yep getting those merged in today though |
ahmedetefy
force-pushed
the
cra-metrics/delete-metrics-cra
branch
from
e9552bd to
3bbbe34
Compare
ahmedetefy
changed the title
ahmedetefy
force-pushed
the
cra-metrics/delete-metrics-cra
branch
from
3bbbe34 to
7ae9bcf
Compare
ahmedetefy
force-pushed
the
cra-metrics/delete-metrics-cra
branch
from
7ae9bcf to
6fdd7ca
Compare
ahmedetefy
force-pushed
the
cra-metrics/delete-metrics-cra
branch
from
6fdd7ca to
2f61d79
Compare
untitaker
approved these changes
Dec 16, 2021
Updates subscription deletion to use the new snuba endpoint that includes the entity key
ahmedetefy
force-pushed
the
cra-metrics/delete-metrics-cra
branch
from
2f61d79 to
a289878
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entity_keyFor context: getsentry/snuba#2244