javascript: Improve gzip/deflate artifacts from ReleaseFiles#4677
Merged
mattrobenolt merged 3 commits intomasterfrom Dec 15, 2016
Merged
javascript: Improve gzip/deflate artifacts from ReleaseFiles#4677mattrobenolt merged 3 commits intomasterfrom
mattrobenolt merged 3 commits intomasterfrom
Conversation
This is unnecessary because python-memcached will gzip for us. By doing this ourselves, we're actually adding extra work by double gzipping.
mitsuhiko
suggested changes
Dec 15, 2016
Contributor
There was a problem hiding this comment.
going to be a party pooper but 'application/json' does not accept a charset :P
mitsuhiko
approved these changes
Dec 15, 2016
Contributor
|
The comment should not require a change to this PR. But we should not do this mistake. |
mattrobenolt
force-pushed
the
zlib-js
branch
from
7218329 to
be0cad5
Compare
mattrobenolt
force-pushed
the
zlib-js
branch
from
be0cad5 to
ffb33a7
Compare
Contributor
|
|
Contributor
Author
|
Had to revert because things slowed down pretty drastically and not clear what the cause is without some investigation. |
|
Is this line in the 8.12 changelog inaccurate, then?
|
Contributor
Author
|
Oh. Wups. Yes, this is inaccurate. The code landed, then had to be reverted. I'll fix this up.
…--
Matt Robenolt
@mattrobenolt
On Thu, Jan 26, 2017 at 5:36 AM -0800, "Samuel Reed" <notifications@github.com> wrote:
Is this line in the 8.12 changelog inaccurate, then?
Allow gziped/deflated JavaScript artifacts to be uploaded through the API.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Any news on that? |
|
@mattrobenolt is this issue fixed and deployed? |
|
Any update? This would be a big improvement for my team, time wise. We have ~30mb of sourcemaps, which is quite slow to upload. |
|
Same here. (100+ mo of sourcemaps ... ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-4566
/cc @benvinegar