fix(compactSelect): Fix scrolling issue due to live-announcer#49777
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
evanpurkhiser
approved these changes
May 25, 2023
volokluev
pushed a commit
that referenced
this pull request
May 30, 2023
Fix a scrolling issue coming from `CompactSelect` in grid mode, specifically the `LiveAnnouncer` element: https://github.com/getsentry/sentry/assets/44172267/171b3ca1-c61e-43b0-9ac5-be830a2f91af This was a `react-aria` issue and was fixed in adobe/react-spectrum#3807. We just need to upgrade `@react-aria/gridlist`. After upgrading, the `LiveAnnouncer` element is always 1px wide/tall and won't cause any scrolling issue. <img width="1543" alt="image" src="https://github.com/getsentry/sentry/assets/44172267/3b2d9b25-c056-4e7f-9004-48f5ab1e7075">
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a scrolling issue coming from
CompactSelectin grid mode, specifically theLiveAnnouncerelement:Screen.Recording.2023-05-25.at.10.37.14.AM.mov
This was a
react-ariaissue and was fixed in adobe/react-spectrum#3807. We just need to upgrade@react-aria/gridlist.After upgrading, the
LiveAnnouncerelement is always 1px wide/tall and won't cause any scrolling issue.