Skip to content

Conversation

@tustanivsky
Copy link
Contributor

This PR adds an example of manual plugin configuration for the Unreal Engine project wizard and highlights the use of the SendDefaultPii option (getsentry/team-sdks#121).

Related UE plugin documentation update: getsentry/sentry-docs#13435

This also highlights `SendDefaultPii` setting usage
@tustanivsky tustanivsky requested a review from a team as a code owner April 17, 2025 12:34
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 17, 2025
Co-authored-by: Simon Hellmayr <shellmayr@users.noreply.github.com>
@tustanivsky
Copy link
Contributor Author

Lint errors were fixed in 81a3c39

@tustanivsky
Copy link
Contributor Author

@priscilawebdev Can certain CI checks (like Vercel deployment or dispatch) fail because this PR comes from a public fork? It seems these require approval from someone at getsentry with write access to this repo.

@priscilawebdev priscilawebdev added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Apr 24, 2025
@priscilawebdev
Copy link
Member

@priscilawebdev Can certain CI checks (like Vercel deployment or dispatch) fail because this PR comes from a public fork? It seems these require approval from someone at getsentry with write access to this repo.

yes! I just triggered the tests for this PR 😉

@priscilawebdev
Copy link
Member

I approved Vercel deployment but it does not seem to work 🤔

@github-actions github-actions bot removed the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Apr 28, 2025
{
Settings->Dsn = TEXT("${params.dsn.public}");
// Add data like request headers, user ip address, device name, etc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no request header in Unreal though. What would be the right comment?

Suggested change
// Add data like request headers, user ip address, device name, etc.
// Add data like ip address and device name

We should link to the docs page we're creating where we list what this is

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I've just added "Data Collected" page to docs (https://docs.sentry.io/platforms/unreal/data-management/data-collected/) and will link it here as well

@bruno-garcia
Copy link
Member

Approved vercel preview, lets see if that works

@bruno-garcia
Copy link
Member

bruno-garcia commented Apr 28, 2025

I approved Vercel deployment but it does not seem to work 🤔

yeah me too

Might be now because there was another commit
image

@bruno-garcia
Copy link
Member

Vercel running again

@bruno-garcia bruno-garcia enabled auto-merge (squash) April 29, 2025 15:19
@bruno-garcia
Copy link
Member

Run python3 -uS .github/workflows/scripts/getsentry-dispatch-setup
permissions failed!

  • has write permission: False
  • has [Trigger: getsentry tests] label: False
  • args.label_names: ['Scope: Frontend']
    please have a collaborator add the [Trigger: getsentry tests] label once they have reviewed the code to trigger downstream tests.
    Error: Process completed with exit code 1.

@colin-sentry colin-sentry added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Apr 29, 2025
@bruno-garcia bruno-garcia merged commit 7ec413a into getsentry:master Apr 29, 2025
45 of 46 checks passed
andrewshie-sentry pushed a commit that referenced this pull request May 12, 2025
…i` usage (#89849)

This PR adds an example of manual plugin configuration for the Unreal
Engine project wizard and highlights the use of the `SendDefaultPii`
option (getsentry/team-sdks#121).

Related UE plugin documentation update:
getsentry/sentry-docs#13435

---------

Co-authored-by: Simon Hellmayr <shellmayr@users.noreply.github.com>
Co-authored-by: Priscila Oliveira <priscilawebdev@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2025
@tustanivsky tustanivsky deleted the unreal/send-default-pii branch September 8, 2025 05:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants