fix(forms): Correct ref and prop passing for textareas#9233
Merged
evanpurkhiser merged 2 commits intomasterfrom Aug 30, 2018
Merged
fix(forms): Correct ref and prop passing for textareas#9233evanpurkhiser merged 2 commits intomasterfrom
evanpurkhiser merged 2 commits intomasterfrom
Conversation
Member
Author
|
enzymejs/enzyme#1592 has been merged. Now we're just waiting for a new version of enzyme. |
Member
Author
|
Waiting on #9542 |
evanpurkhiser
force-pushed
the
fixforms-correct-ref-and-prop-passing-for-textareas
branch
from
bdab1cf to
c8a4951
Compare
billyvg
approved these changes
Aug 30, 2018
evanpurkhiser
deleted the
fixforms-correct-ref-and-prop-passing-for-textareas
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is going to fail tests. We need this: enzymejs/enzyme#1604.
enzymejs/enzyme#1604 (comment) unfortunately does not fix our issue (even though it says it does, enzymejs/enzyme#1513 (comment) it is backed up that it does not here)