ref(astro): Check for Astro 4 config.devToolbar in Spotlight integration#212
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matthewp
reviewed
Dec 4, 2023
| } | ||
| // Since Astro 4.0.0-beta.4, `devToolbar` is set and enabled by default. | ||
| // briefly, `devOverlay` was also added to the config but is now deprecated. | ||
| // Setting either of these to `true` or not setting any of them in the config file |
Member
Author
There was a problem hiding this comment.
No worries, this is nothing compared to what we have to do in some other frameworks 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorporate changes from withastro/astro#9271
We now prefer the new
devToolbarandaddDevToolbarAppAPIs over the overlay terms and check for the top-level config options correctly.Upgraded to Astr 4 beta for types and added backward-compatible type cast (should be safe) to remove a few
ts-ignores we previously threw in.closes #211