feat(sourcebundle): Add callback to handle skipped files#864
feat(sourcebundle): Add callback to handle skipped files#864szokeasaurusrex merged 4 commits intomasterfrom
Conversation
Add a callback to SourceBundleWriter that is called every time we skip adding a file to the bundle due to a ReadFailed error. Closes #863
|
loewenheim
left a comment
There was a problem hiding this comment.
This is an elegant way of doing it!
Yeah, many thanks to @jan-auer for helping me to come up with this idea! We are fully backwards compatible in this way |
|
@loewenheim I also had the idea that we could similarly add a |
It's something to think about. |
Co-authored-by: Jan Michael Auer <jan.auer@sentry.io>
|
Since #860 was closed, does that mean that sentry-cli also handles this now in some way already? What would be the behavior now when a file is to be skipped? Bail out, warning, or silent debug log? (assuming either option would now log the file name) |
Add a callback to SourceBundleWriter that is called every time we skip adding a file to the bundle due to a ReadFailed error.
Also, #861 missed another spot where the ReadFailed error can cause the write function to fail; this PR fixes that.
Closes #863
Fixes #860