This repository was archived by the owner on Apr 24, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
This repository was archived by the owner on Apr 24, 2025. It is now read-only.
Chore: Align/extend User Agents #61
Copy link
Copy link
Closed
Description
Description
Currently, some SDKs (e.g. sentry-cocoa) don't set a user agent or just set the SDK name as user agent.
In an effort to make troubleshooting of issues more viable if only the http request headers are available (e.g. looking into LB issues), we want to add more information to the user agent:
- SDK name + version
- OS name + version
### Define base and optional/additional format
- [ ] https://github.com/getsentry/develop/pull/1222
### Ensure SDKs use base format
- [ ] https://github.com/getsentry/sentry-cocoa/issues/3713
- [ ] https://github.com/getsentry/sentry-java/issues/3274
- [x] React Native
- [ ] https://github.com/getsentry/sentry-native/issues/957
- [x] [PHP](https://github.com/getsentry/sentry-php/blob/master/src/HttpClient/HttpClient.php?rgh-link-date=2024-02-28T16%3A33%3A16Z#L66)
- [x] [Go](https://github.com/getsentry/sentry-go/blob/master/transport.go?rgh-link-date=2024-02-28T16%3A33%3A16Z#L212)
- [x] [Python](https://github.com/getsentry/sentry-python/blob/e07a128a5ff6e646421ee14bce7b5856d8d6896c/sentry_sdk/transport.py#L152)
- [x] [Ruby](https://github.com/getsentry/sentry-ruby/blob/7d29d3c69e3ae76a6c0be8e2778e0829b3a9641e/sentry-ruby/lib/sentry/transport/http_transport.rb#L15)
- [ ] Node (TODO, see https://github.com/getsentry/develop/pull/1222#discussion_r1567465462)
- [ ] …add more SDKs to check here…
### (Optional) Adopt optional/additional format in SDKs
- [ ] https://github.com/getsentry/sentry-dart/issues/1901
- [ ] …add more SDKs to implement here…
Why should we be doing this?
To make troubleshooting of issues more viable if only the http request headers are available, e.g. in incidents like INC-648
Why now?
The earlier we add at least the basic info (SDK name+version), the higher the likelihood that we have useful information available during the next incident.
RFC
No response
Slack-Channel
Notion Document(s)
Stakeholder(s)
INC-648, SRE
Team(s)
Mobile
Web Backend
Web Frontend (?)
mwarkentin
Metadata
Metadata
Assignees
Projects
Status
Done