version: rewrite command to use GitHub endpoints#1261
Merged
Conversation
hiddeco
force-pushed
the
version-cmd-gh-api
branch
from
262f95f to
41c32bb
Compare
hiddeco
changed the title
hiddeco
force-pushed
the
version-cmd-gh-api
branch
6 times, most recently
from
c8a21b7 to
75d3ce6
Compare
Contributor
felixfontein
left a comment
felixfontein
left a comment
There was a problem hiding this comment.
Besides that, LGTM!
Signed-off-by: Hidde Beydals <hidde@hhh.computer>
This changes the logic of parsing the `version.go` file from a certain branch to instead make use of the GitHub latest release redirect or API[1] endpoints for checking if `sops` is on the latest version. Detaching any future release of SOPS from specific file structures and/or branches, and (theoretically) freeing it from the requirement of having to bump the version in-code during release (as this is also done using `-ldflags` during build). Were it not for the fact that we have to maintain it for backwards compatibility. [1]: https://docs.github.com/en/free-pro-team@latest/rest/releases/releases?apiVersion=2022-11-28#get-the-latest-release Signed-off-by: Hidde Beydals <hidde@hhh.computer>
hiddeco
force-pushed
the
version-cmd-gh-api
branch
from
75d3ce6 to
e26844d
Compare
felixfontein
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on difficulties observed in #1238 (comment)
This changes the logic of parsing the
version.gofile from a certainbranch to instead make use of the GitHub latest release redirect or
API1 endpoints for checking if
sopsis on the latest version.Detaching any future release of SOPS from specific file structures
and/or branches, and (theoretically) freeing it from the requirement of
having to bump the version in-code during release (as this is also done
using
-ldflagsduring build). Were it not for the fact that we haveto maintain it for backwards compatibility.