Skip to content

Add separate subcommands for encryption, decryption, rotating, editing, and setting values#1391

Merged
felixfontein merged 2 commits into
getsops:mainfrom
felixfontein:subcommands-2
Feb 9, 2024
Merged

Add separate subcommands for encryption, decryption, rotating, editing, and setting values#1391
felixfontein merged 2 commits into
getsops:mainfrom
felixfontein:subcommands-2

Conversation

@felixfontein
Copy link
Copy Markdown
Contributor

@felixfontein felixfontein commented Dec 26, 2023

This is another Work in Progress for exploring how to implement #1333, similar to the original WIP #1343. Right now the new subcommands are basically a stripped-down copy'n'paste of the current "main" command. This PR based upon #1389, which reduces the copy'n'paste a lot.

Fixes #1333

This PR includes the PRs #1389 and #1390. I will rebase once these are merged.

Signed-off-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein marked this pull request as ready for review February 6, 2024 14:04
@felixfontein
Copy link
Copy Markdown
Contributor Author

Now that #1389 has been merged, this is ready for review! 🎉

Copy link
Copy Markdown
Member

@hiddeco hiddeco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @felixfontein! 🙇

@hiddeco hiddeco added this to the v3.9.0 milestone Feb 9, 2024
@felixfontein felixfontein merged commit 38ef8a8 into getsops:main Feb 9, 2024
@felixfontein felixfontein deleted the subcommands-2 branch February 9, 2024 20:09
@felixfontein
Copy link
Copy Markdown
Contributor Author

@hiddeco thanks a lot for reviewing this!

Dexmachi added a commit to Ch-aOS-Ch/Ch-aOS that referenced this pull request May 7, 2026
"sops decrypt" instead of "sops -e" and "sops -d" respectively.
as described in [this sops issue](getsops/sops#1333),
the short flags for encrypt and decrypt are being deprecated in favor of
a more scoped command structure. This change will help us stay compliant
with the latesst version of sops and avoid any potential issues with future updates.

For more details, refer to [this sops
PR](getsops/sops#1333), and [this other sops
PR](getsops/sops#1391).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make encrypt, decrypt, rotate, set, and edit proper commands

2 participants