chore(deps): Update Go dependencies#1527
Conversation
reneleonhardt
force-pushed
the
updates
branch
5 times, most recently
from
227b53b to
8de8db6
Compare
felixfontein
left a comment
felixfontein
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I think your PR is doing way too many things in one PR that should happen in multiple smaller PRs. Can you please split it up into smaller parts, such as:
- Updating Go deps.
- Extending CI to build multiple deps.
- Updating the release process and using dependabot for updating Dockerfile.
- Updating Rust dependencies and using dependabot for updating Cargo.toml.
- Updating Makefile.
Thanks!
reneleonhardt
force-pushed
the
updates
branch
2 times, most recently
from
14c78b6 to
de2a7c0
Compare
reneleonhardt
changed the title
| uses: goreleaser/goreleaser-action@286f3b13b1b49da4ac219696163fb8c1c93e1200 # v6.0.0 | ||
| with: | ||
| version: 1.21.x | ||
| version: 1.22.x |
There was a problem hiding this comment.
This is not the Go version BTW, but the goreleaser version.
Ref: #1547 (comment)
There was a problem hiding this comment.
Interesting, this is confusing, why would you use a goreleaser version from Sept 2023 if 1.26.x is the last 1.x? 🤔
I suggest "updating" to 1.26 first, but 2.1 is around the corner...
There was a problem hiding this comment.
Because the last person who updated the version also thought it is a Go version (which it is not). I would avoid updating this at all until we have proper packaging testing (see #1547 for what the update from 1.20.x to 1.21.x caused).
Signed-off-by: Rene Leonhardt <65483435+reneleonhardt@users.noreply.github.com>
reneleonhardt
force-pushed
the
updates
branch
from
7b024c2 to
c6919bd
Compare
|
Closing since this is pretty outdated. Thanks for your contribution. |
2 participants
Features