-
Notifications
You must be signed in to change notification settings - Fork 9
Description
Since stuff has been moving, it seems like it will just be more and more difficult to keep patching it to get it working. Turns out scipy already has bindings for all of the blas/lapack stuff, and they are all here: https://github.com/getspams/spams-python/blob/main/spams_wrap/linalg/cblas_alt_template.h
It contains definitions to accommodate a few common patterns for the function to link directly to a user supplied lib for blas/lapack, but could likely be replaced by cimporting the whole bunch of stuff here https://docs.scipy.org/doc/scipy/reference/linalg.cython_blas.html and here https://docs.scipy.org/doc/scipy/reference/linalg.cython_blas.html
The end result would be to always rely on whatever scipy is using (and bundling), without having to find and distribute our own, instead relying on a cython file to do it. This would also fix the compute server since they likely use their own optimised builds for the rest of the scientific stack. Not unlike what is found in https://github.com/getspams/spams-cython/tree/main/cyspams, we could remove the whole trying to find libs and rely on that instead.
Disclaimer: might sounds easier than it is to do, but it really looks like re-doing an interface to grab the scipy version instead of the redefined internal versions the wrapper is doing would be it. @daducci @nightwnvol