Merged
Conversation
Contributor
|
@samuelstjean thanks, that's great. I was thinking that we should do that when working on the I'll run some tests on my side but from the file review, it should be ok. Thanks again! 👍 Regarding the automatic setup. I am working on a major release of another software right now. I hope to find some time to do that in a couple of weeks. |
Contributor
|
I tested without any problem on Linux (Python 3.10, 3.9, 3.8, 3.7, and even discontinued 3.5... and MacOS 3.9), I think we can merge this. Thanks again 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed old files for compat with old scipy and py 2.7, allowing to drop some old modules that are not needed. All test seems to still work fine here. I suggest turning out whitespace diff to view the changes though.
I also have some big changes for windows compat/swig 4 wrappers, but that should wait until we have an automatic setup to be safe and to check if it makes everything slower or not.