Server - Sampling bug fix#10019
Merged
ggerganov merged 1 commit intoggml-org:masterfrom Oct 23, 2024
wwoodsTM:server-sampling-fix
Merged
Server - Sampling bug fix#10019ggerganov merged 1 commit intoggml-org:masterfrom wwoodsTM:server-sampling-fix
ggerganov merged 1 commit intoggml-org:masterfrom
wwoodsTM:server-sampling-fix
Conversation
4 tasks
ggerganov
approved these changes
Oct 23, 2024
ngxson
approved these changes
Oct 23, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 15, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Nov 18, 2024
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This stems from #9702, but as requested by @ggerganov is being separated out from that larger PR.
This PR specifically addresses the issue where the complete prompt was not being passed to the sampling system. I believe this fixes #8971.