ggml: aarch64: implement SVE kernels for q4_K_q8_K vector dot#11227
Merged
ggerganov merged 2 commits intoggml-org:masterfrom Jan 16, 2025
Merged
ggml: aarch64: implement SVE kernels for q4_K_q8_K vector dot#11227ggerganov merged 2 commits intoggml-org:masterfrom
ggerganov merged 2 commits intoggml-org:masterfrom
Conversation
ggerganov
approved these changes
Jan 14, 2025
Member
|
Could you post the results of the following command: llama-bench --model ${PATH_TO_MODEL} -p 1,2,4,8,512 -t 8,16,32,48 |
Contributor
Author
|
Thank you for your quick reply. Original(NEON)This PR(SVE) |
change to use K_SCALE_SIZE Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Feb 26, 2025
…rg#11227) * Add SVE support for q4_K_q8_K * Update ggml/src/ggml-cpu/ggml-cpu-quants.c change to use K_SCALE_SIZE Co-authored-by: Georgi Gerganov <ggerganov@gmail.com> --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
Member
|
@fj-y-saito I suspect that there is a bug in this change. Recently the Github CI Arm runners started supporting SVE and I noticed that one of the |
Contributor
Author
|
OK I'll check. |
Contributor
Author
|
I think the test program is missing This fix now passes the test in my environment. |
This was referenced Mar 10, 2025
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
…rg#11227) * Add SVE support for q4_K_q8_K * Update ggml/src/ggml-cpu/ggml-cpu-quants.c change to use K_SCALE_SIZE Co-authored-by: Georgi Gerganov <ggerganov@gmail.com> --------- Co-authored-by: Georgi Gerganov <ggerganov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for SVE(Scalable Vector Extensions) kernels for the q4_K_q8_K vector dot on the Arm architecture. A similar proposal for SVE support is made in PR #7433.
Verifying Features
This PR contains the SVE implementation of the vector dot used to compute the Q4_K quantization.
By running a Q4_K_M quantized model of Llama-3.1-8B, I confirmed that the values match.
The values of the NEON and SVE implementations were compared one after another, and it was confirmed that the values always match.
I also verified that the perplexity matches between the NEON and SVE implementations.
performance check
Performance was measured with FX700.
Performance is improved as follows. The value is tokens per second.
The command used to measure the performance is