Add PLM GGUF Conversion & Inference Support#12457
Merged
ggerganov merged 41 commits intoggml-org:masterfrom Mar 27, 2025
Si1w:master
Merged
Add PLM GGUF Conversion & Inference Support#12457ggerganov merged 41 commits intoggml-org:masterfrom Si1w:master
ggerganov merged 41 commits intoggml-org:masterfrom
Si1w:master
Conversation
ngxson
reviewed
Mar 19, 2025
Contributor
|
Tested both the premade gguf and converting the gguf, both work 👍 Looks like it's using the qwen2 tokenizer with the associated chatml prompt template: The only small error was a brief switch in language, but that's probably not related to this PR: convert_hf_to_gguf.py output: |
ngxson
reviewed
Mar 19, 2025
ggerganov
reviewed
Mar 21, 2025
Contributor
Author
|
@ggerganov @slaren @ngxson I have already fixed the problem and tested models, could you help review again and merge? Thanks in advance |
ggerganov
approved these changes
Mar 27, 2025
Member
|
@Si1w What is the difference between the "instruct" and "instruct-id" models? |
ngxson
approved these changes
Mar 27, 2025
Contributor
Author
Basically, there is no significant difference but "instruct-id" is that model with identification i.e. the model knows that its name is plm. |
Member
|
Let's merge if CI is green. |
Seunghhon
pushed a commit
to Seunghhon/llama.cpp
that referenced
this pull request
Apr 26, 2026
* add edgellm model arch[conversation feature doesn't work] * remove output.weight layer for edgellm arch * [Model] update the name of the model * update the name of model arch in convert gguf * [Model] Refarctor the model arch into llama-model * [Bug] Fix the bug in create attn kv * [Code] Fix editorconfig erros * [Code] Remove Trailing whitespace * [Code] Remove Trailing whitespace * [Code] Change the order of model arch in list * [Code] Fix flake8 Lint errors * Remove trailing white space * [Code] Remove call in model arch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds HF->GGUF conversion & inference support for PLM Model PLM-1.8B-Instruct
The Model has already been converted into
ggufform with quantized and tested PLM-1.8B-Instruct-gguf, PLM-1.8B-Instruct-id-ggufThe Model Arch is similar with Deepseek V2 and Minicpm3. The key points of the model are:
The details of the model can be seen in the following Paper
PLM: Efficient Peripheral Language Models Hardware-Co-Designed for Ubiquitous Computing
Self-reported review complexity: