Break down main function in llama-server#13425
Closed
ericcurtin wants to merge 1 commit intomasterfrom
Closed
Conversation
Collaborator
Author
|
Incomplete |
llama-server main function is getting meaty, just breaking it down into smaller functions. Signed-off-by: Eric Curtin <ecurtin@redhat.com>
ericcurtin
force-pushed
the
refactor-server
branch
from
a28bb23 to
5c32fc3
Compare
Contributor
|
Before going further, I think it's better to discuss a plan rather than diving into the code. While working on #13400 (comment) , I also thought about refactoring For now, the most simple task is of course to abstract out the creation of HTTP server. Second task could be to move all the HTTP handler to a completely separated file. The main component, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
llama-server main function is getting meaty, just breaking it down into smaller functions.